Page MenuHomePhabricator
Create Task
Maniphest T119691

Properly use language templates in cross-wiki upload
Closed, ResolvedPublic
Actions

Description

Symptom: Over the last time several files uploaded by the cross-wiki upload appear in https://commons.wikimedia.org/wiki/Category:Language_templates_with_no_text_displayed, e. g. https://commons.wikimedia.org/wiki/File:Kmeans2.png.

Reason: This is because the description contains {{en|...}} instead of the more safe {{en|1=...}}. The latter one is more safe when the description contains special characters such as =.

Solution: Please modify ForeignStructuredUpload.prototype.getDescriptions accordingly.

Details

SubjectRepoBranchLines +/-
Revert "mediawiki.ForeignStructuredUpload: Always use '|1=' for description templates"mediawiki/coremaster+3 -2
mediawiki.ForeignStructuredUpload: Always use '|1=' for description templatesmediawiki/coremaster+2 -3
|1= should be always used. Following standard on commons.mediawiki/corewmf/1.27.0-wmf.7+2 -3
mediawiki.ForeignStructuredUpload: Behave correctly when '=' appears in a descriptionmediawiki/corewmf/1.27.0-wmf.7+3 -2
mediawiki.ForeignStructuredUpload: Behave correctly when '=' appears in a descriptionmediawiki/coremaster+3 -2
Customize query in gerrit

Event Timeline

Aschroet created this task.Nov 26 2015, 9:33 AM
Aschroet raised the priority of this task from to Needs Triage.
Aschroet updated the task description. (Show Details)
Aschroet added projects: MediaWiki-Uploading, Commons.
Aschroet subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptNov 26 2015, 9:33 AM
Restricted Application added subscribers: StudiesWorld, Steinsplitter, Aklapper. · View Herald Transcript
zhuyifei1999 moved this task from Incoming to Backlog on the Commons board.Nov 26 2015, 11:38 AM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptNov 26 2015, 11:38 AM
zhuyifei1999 moved this task from Backlog to Uploading on the Commons board.Nov 26 2015, 11:38 AM
zhuyifei1999 subscribed.
matmarex claimed this task.Nov 26 2015, 2:09 PM
matmarex triaged this task as High priority.Nov 26 2015, 6:18 PM
gerritbot subscribed.Nov 26 2015, 6:36 PM

Change 255559 had a related patch set uploaded (by Bartosz Dziewoński):
mediawiki.ForeignStructuredUpload: Behave correctly when '=' appears in a description

https://gerrit.wikimedia.org/r/255559

gerritbot added a project: Patch-For-Review.Nov 26 2015, 6:36 PM
gerritbot added a comment.Nov 30 2015, 5:15 PM

Change 255559 merged by jenkins-bot:
mediawiki.ForeignStructuredUpload: Behave correctly when '=' appears in a description

https://gerrit.wikimedia.org/r/255559

gerritbot added a comment.Nov 30 2015, 5:16 PM

Change 256028 had a related patch set uploaded (by Jforrester):
mediawiki.ForeignStructuredUpload: Behave correctly when '=' appears in a description

https://gerrit.wikimedia.org/r/256028

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), MW-1.27-release-notes.Nov 30 2015, 6:00 PM
Aschroet added a comment.Nov 30 2015, 6:18 PM

@Jforrester, i do not understand why we need to introduce such a complexity by this patch. Explicitly addressing the first parameter by "1=" is always the better choice. All tools such as Upload Wizard etc. do it. Thus, Bartosz' solution is more clean and sufficient.

Jdforrester-WMF subscribed.Nov 30 2015, 6:27 PM
In T119691#1839124, @Aschroet wrote:

@Jforrester, i do not understand why we need to introduce such a complexity by this patch. Explicitly addressing the first parameter by "1=" is always the better choice. All tools such as Upload Wizard etc. do it. Thus, Bartosz' solution is more clean and sufficient.

Writing bad wikitext because other tools write bad wikitext is a poor excuse.

gerritbot added a comment.Dec 1 2015, 12:11 AM

Change 256028 merged by jenkins-bot:
mediawiki.ForeignStructuredUpload: Behave correctly when '=' appears in a description

https://gerrit.wikimedia.org/r/256028

matmarex closed this task as Resolved.Dec 1 2015, 12:50 AM

Fixed and deployed.

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-17_(1.27.0-wmf.7)).Dec 1 2015, 1:00 AM
Steinsplitter added a comment.Dec 6 2015, 7:16 AM

1= should be used always.

gerritbot added a comment.Dec 6 2015, 7:22 AM

Change 257172 had a related patch set uploaded (by Steinsplitter):

1= should be always used. Following standard on commons.

https://gerrit.wikimedia.org/r/257172

gerritbot added a comment.Dec 6 2015, 9:03 AM

Change 257174 had a related patch set uploaded (by Zhuyifei1999):

1= should be always used. Following standard on commons.

https://gerrit.wikimedia.org/r/257174

gerritbot added a comment.Dec 6 2015, 9:29 AM

Change 257172 abandoned by TTO:

1= should be always used. Following standard on commons.

Reason:
Superseded by Ied787ecb91aaae3f643c9d013b8982ddabea8142

https://gerrit.wikimedia.org/r/257172

gerritbot added a comment.Dec 6 2015, 1:50 PM

Change 257174 merged by jenkins-bot:
mediawiki.ForeignStructuredUpload: Always use '|1=' for description templates

https://gerrit.wikimedia.org/r/257174

Jdforrester-WMF added a comment.Dec 7 2015, 4:13 PM
In T119691#1856394, @Steinsplitter wrote:

1= should be used always.

Can you please explain why you think that's better for users? It's 'broken' (working but stupid) wikitext. Just because UploadWizard fails to use the right syntax doesn't mean it's "policy".

Steinsplitter added a comment.EditedDec 7 2015, 5:10 PM
In T119691#1858451, @Jdforrester-WMF wrote:
In T119691#1856394, @Steinsplitter wrote:

1= should be used always.

Can you please explain why you think that's better for users? It's 'broken' (working but stupid) wikitext. Just because UploadWizard fails to use the right syntax doesn't mean it's "policy".

Please elaborate why it is "broken" wkitext.
It is used by multiple tools. We should try to use always the same sintax. If you believe the current use of |1= is "broken" then i invite you to star a proposal at the village pump for proposals on commons

Creating a policy for such a case would be over bureaucratic, commons sense should be used :-).

Please elaborate why you reverted the patch in https://gerrit.wikimedia.org/r/#/c/257350/ without +1 by the community.

gerritbot added a comment.Dec 7 2015, 5:26 PM

Change 257350 had a related patch set uploaded (by Jforrester):
Revert "mediawiki.ForeignStructuredUpload: Always use '|1=' for description templates"

https://gerrit.wikimedia.org/r/257350

Jdforrester-WMF added a comment.Dec 7 2015, 5:31 PM
In T119691#1858747, @Steinsplitter wrote:
In T119691#1858451, @Jdforrester-WMF wrote:
In T119691#1856394, @Steinsplitter wrote:

1= should be used always.

Can you please explain why you think that's better for users? It's 'broken' (working but stupid) wikitext. Just because UploadWizard fails to use the right syntax doesn't mean it's "policy".

Please elaborate why it is "broken" wkitext.

As editors, we repeatedly have to explain to users the complex ways in how templates work. Adding extra uses adds to this complexity and makes it harder for people to learn. In general we have a policy that we simplify things for users, so things work as they would expect and are only different when they need to be different. It's the same for interfaces, for wording, for iconography, and it should also be the same for wikitext.

It is used by multiple tools.

OK. Which ones? Can you point me to any design documents? Are they using it because it's a good idea or just because you want them to do so? :-)

We should try to use always the same sintax.

I agree. But I think you're thinking of more limited cases for "the same". I'm thinking of citations, infoboxen, conversion templates and the millions of other uses of this syntax.

If you believe the current use of |1= is "broken" then i invite you to star a proposal at the village pump for proposals on commons

I think that's really bureaucratic. Hundreds of changes go out each week. Why do you think this needs a discussion first? Is it that surprising?

Creating a policy for such a case would be over bureaucratic, commons sense should be used :-).

I agree – but I think common sense is to use the normal form.

Please elaborate why you reverted the patch in https://gerrit.wikimedia.org/r/#/c/257350/ without +1 by the community.

I haven't reverted anything yet, I've proposed a revert of your requested revert of MatmaRex's patch which I had asked him to make.

Steinsplitter added a comment.EditedDec 7 2015, 5:46 PM

! In T119691 @Jdforrester-WMF wrote:

Thanks for the fats reply :-)

OK. Which ones? Can you point me to any design documents? Are they using it because it's a good idea or just because you want them to do so? :-)

https://commons.wikimedia.org/wiki/Template:En#Usage is the relevant documentation.

I haven't reverted anything yet, I've proposed a revert of your requested revert of MatmaRex's patch which I had asked him to make.

Ok. Sorry for the misunderstanding.

zhuyifei1999 added a comment.Dec 8 2015, 12:15 AM
In T119691#1858906, @Jdforrester-WMF wrote:

Please elaborate why it is "broken" wkitext.

As editors, we repeatedly have to explain to users the complex ways in how templates work. Adding extra uses adds to this complexity and makes it harder for people to learn. In general we have a policy that we simplify things for users, so things work as they would expect and are only different when they need to be different. It's the same for interfaces, for wording, for iconography, and it should also be the same for wikitext.

The problem here is that it is currently impossible to use wikitext logically on language templates, when a user have to add a url with params (or other sources of equals sign) to a language template. While "|1=" does not look beautiful, it eliminate the possible confusion when a user find the language template completely gone after adding stuffs.

Tgr subscribed.Dec 8 2015, 1:01 AM

@Jdforrester-WMF I guess the question is whether we would rather confuse users by adding a strange 1= to their edits even when it is not strictly necessary or by exposing them to strange breakage when they try to edit the description later and add an =. The first seems less painful to me.

Jdforrester-WMF added a comment.Dec 9 2015, 6:26 PM
In T119691#1860903, @zhuyifei1999 wrote:

The problem here is that it is currently impossible to use wikitext logically on language templates, when a user have to add a url with params (or other sources of equals sign) to a language template. While "|1=" does not look beautiful, it eliminate the possible confusion when a user find the language template completely gone after adding stuffs.

If the user is not competent to edit wikitext and know to put 1=, they should use the visual editor.

Aschroet added a comment.Dec 17 2015, 6:57 AM

What is the status of the ticket in terms of code? Is one of the solutions already in production?

matmarex added a comment.Dec 17 2015, 12:57 PM

Yes. The original fix (using '|' or '|1=' as needed) was deployed on December 1, as noted above; Steinsplitter's change to always use '|1=' was deployed with MediaWiki 1.27.0-wmf.8 last week. James's revert of that to the original fix is in review/discussion. Either way, the original issue is fixed.

gerritbot added a comment.Feb 18 2021, 5:44 PM

Change 257350 abandoned by Krinkle:
[mediawiki/core@master] Revert "mediawiki.ForeignStructuredUpload: Always use '|1=' for description templates"

Reason:
Assuming not.

https://gerrit.wikimedia.org/r/257350

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL