Page MenuHomePhabricator

Special:Preferences does not display unsaved preferences warning if changes made before JS is done loading
Closed, ResolvedPublic

Description

If changes in preferences are made before JavaScript is done asynchronously loading, then the "Warning, preferences are not saved" message does not appear when the user leaves, reloads etc. the page. Similar to T112379. The original preference data should be saved before the page is done loading. derp, this is already done in PHP with defaultValue

Event Timeline

Sn1per created this task.Nov 26 2015, 5:03 PM
Sn1per updated the task description. (Show Details)
Sn1per raised the priority of this task from to Low.
Sn1per claimed this task.
Sn1per added a subscriber: Sn1per.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 26 2015, 5:03 PM
Sn1per updated the task description. (Show Details)Nov 26 2015, 5:11 PM
Sn1per set Security to None.

Change 255652 had a related patch set uploaded (by Sn1per):
Check each Special:Preferences input for changes

https://gerrit.wikimedia.org/r/255652

Change 255652 merged by jenkins-bot:
Check each Special:Preferences input for changes

https://gerrit.wikimedia.org/r/255652

TheDJ closed this task as Resolved.Dec 25 2015, 11:50 PM
TheDJ added a subscriber: TheDJ.