Page MenuHomePhabricator

RESTBase doesn't purge restored/recreated pages -> VisualEditor unable to edit restored/recreated pages
Closed, ResolvedPublic0 Estimated Story Points

Description

With VisualEditor on the page https://test2.wikipedia.org/w/index.php?title=Drong-7&oldid=161406&veaction=edit

Put the prompt just after (à tester)
delete with successives backspace (à tester) up to the prompt disappear next to website (don't touch website - official website stays not highlight)

Then Save page
Then Resume editing

Then the wizard is completely blocked (and the page)

MAC OS 10.11.1 - Safari 9.0.1/Chrome 46.0 Reproductible : always

Event Timeline

Drongou raised the priority of this task from to Needs Triage.
Drongou updated the task description. (Show Details)
Drongou added a project: VisualEditor.
Drongou added a subscriber: Drongou.

Uncaught Error: Offset could not be translated to a DOM element and offset: 21 from ve.ce.Document.getNodeAndOffsetUnadjustedForUnicorn

I can't load that page for editing; RB seems to 404 on it?

Since somebody changed the article a very strange thing appears; When you edit the first contribution in the history with VisualEditor the article is completely blank but when you switch to wikitext the text is there : https://test2.wikipedia.org/wiki/Drong-7

I've made a new example for the first incident : https://test2.wikipedia.org/wiki/Drong-8

Jdforrester-WMF renamed this task from Wait unlimited on Resume editing button (in a certain context) to RESTBase doesn't purge restored/recreated pages -> VisualEditor unable to edit restored/recreated pages.Dec 3 2015, 1:30 AM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.

Aha, so, I think this is the 'deletion' equivalent of T110152: RESTBase doesn't purge renamed page -> VisualEditor unable to create moved page. Sorry for the trouble.

The latest revision of that page at https://test2.wikipedia.org/api/rest_v1/page/html/Drong-7/161414 *is* accessible and should be editable in VE, so the issue seems to be specific to that revision. https://en.wikipedia.org/wiki/Drong-7?oldid=161406 is readable however, so this must be some per-revision state in RESTBase's page_title storage blocking this.

Was this revision ever revdeleted or suppressed?

Pchelolo claimed this task.

After https://github.com/wikimedia/restbase/pull/599 was deployed that shouldn't happen any more. Pages recreated before still wouldn't work properly and we can't do anything with that, but newer restored pages will work. Resolving.