Page MenuHomePhabricator
Create Task
Maniphest T119877

[Task] Remove formatter fallback from OutputFormatValueFormatterFactory
Closed, ResolvedPublic
Actions

Description

Drop magic escaping logic from OutputFormatValueFormatterFactory.

Factory callbacks defined via DataTypeDefinitions are now required
directly to provide formatters for all output formats. This allows
us to drop some rather convoluted magic for escaping from the
factory. Magic that would have to be repeated in OutputFormatSnakFormatterFactory
in order to allow it to also use factory callbacks from DataTypeDefinitions.

Details

SubjectRepoBranchLines +/-
Fix all issues from Daniels SnakFormatter refactoringmediawiki/extensions/Wikibasemaster+56 -100
Drop magic escaping logic from OutputFormatValueFormatterFactory.mediawiki/extensions/Wikibasemaster+265 -293
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedBeneT95684 [Story] Format identifiers as Links
ResolveddanielT119877 [Task] Remove formatter fallback from OutputFormatValueFormatterFactory
· · ·

Event Timeline

• Jonas created this task.Nov 30 2015, 3:57 PM
• Jonas assigned this task to daniel.
• Jonas raised the priority of this task from to Medium.
• Jonas updated the task description. (Show Details)
• Jonas added projects: Wikidata-Sprint-2015-11-17, Wikidata, MediaWiki-extensions-WikibaseRepository.
• Jonas subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2015, 3:57 PM
• Jonas moved this task from Proposed to Done on the Wikidata-Sprint-2015-11-17 board.Nov 30 2015, 3:57 PM
• Jonas moved this task from Done to Review on the Wikidata-Sprint-2015-11-17 board.
gerritbot subscribed.Nov 30 2015, 7:29 PM

Change 254064 had a related patch set uploaded (by Jonas Kress (WMDE)):
Drop magic escaping logic from OutputFormatValueFormatterFactory.

https://gerrit.wikimedia.org/r/254064

gerritbot added a project: Patch-For-Review.Nov 30 2015, 7:29 PM
Lydia_Pintscher added a project: Wikidata-Sprint-2015-12-01.Dec 1 2015, 10:06 AM
Lydia_Pintscher set Security to None.
Lydia_Pintscher moved this task from Proposed to Review on the Wikidata-Sprint-2015-12-01 board.Dec 1 2015, 10:11 AM
• Jonas renamed this task from [Task] Remove formatter failback form OutputFormatValueFormatterFactory to [Task] Remove formatter fallback from OutputFormatValueFormatterFactory.Dec 1 2015, 3:09 PM
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Dec 3 2015, 3:39 PM
adrianheine moved this task from Review to Doing on the Wikidata-Sprint-2015-12-01 board.Dec 7 2015, 10:13 AM
gerritbot added a comment.Dec 11 2015, 10:42 AM

Change 258432 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix all issues from Daniels SnakFormatter refactoring

https://gerrit.wikimedia.org/r/258432

gerritbot added a comment.Dec 11 2015, 3:38 PM

Change 254064 merged by jenkins-bot:
Drop magic escaping logic from OutputFormatValueFormatterFactory.

https://gerrit.wikimedia.org/r/254064

gerritbot added a comment.Dec 11 2015, 3:42 PM

Change 258432 merged by jenkins-bot:
Fix all issues from Daniels SnakFormatter refactoring

https://gerrit.wikimedia.org/r/258432

daniel closed this task as Resolved.Dec 18 2015, 3:45 PM
daniel moved this task from Doing to Done on the Wikidata-Sprint-2015-12-01 board.Dec 18 2015, 3:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL