Page MenuHomePhabricator

Search result columns in 1.26.0 not correctly display when using both title and text scope
Closed, ResolvedPublic

Assigned To
Authored By
Ejouvin
Nov 30 2015, 4:06 PM
Referenced Files
F57680020: Screenshot 2024-11-04 at 20.16.45.png
Nov 4 2024, 7:18 PM
F57680021: Screenshot 2024-11-04 at 20.16.51.png
Nov 4 2024, 7:18 PM
F3029705: 2 columns.PNG
Nov 30 2015, 4:06 PM
F3029737: end of line.png
Nov 30 2015, 4:06 PM

Description

Just upgrade to 1.26.0.

When the search returns page with results from title and text content, the columns are not correctly aligned.
(May be something wrong in my CSS alors ?)
As shown in the following screen capture

2 columns.PNG (501×982 px, 68 KB)

More over, there si a \n display at the end of page.

end of line.png (300×834 px, 29 KB)

Correct link to see the result and may be say that the error comes from my CSS :
http://www.jouvinio.net/wiki/index.php?title=Sp%C3%A9cial:Recherche&limit=20&offset=40&profile=default&search=jenkins

Regards.

Etienne Jouvin

Event Timeline

Ejouvin raised the priority of this task from to Needs Triage.
Ejouvin updated the task description. (Show Details)
Ejouvin subscribed.
Aklapper renamed this task from Search results not correctly display when both title and text scope, version 1.26.0 to Search result columns in 1.26.0 not correctly display when using both title and text scope.Dec 1 2015, 12:15 PM
Aklapper added a project: MediaWiki-Search.
Aklapper set Security to None.

I'm confused by the screenshots in this task. Why are there separate results for both titles and content? I am surprised this is an option.

The \n at the end of the page is caused by T113518: trailing \n appearing at the bottom of search results pages on mediawiki.org and meta.wikimedia.org, which was fixed. I'm not certain why you're still seeing it. I'd suggest updating again, as it seems that issue was fixed a few days ago for the 1.26 release.

For the screenshots, the why is the object of my ticket in fact.
Why does it display like that ?

For the trailing \n, I will check the instance if it was correctly updated. But I did deploy 1.26.0 version.

This is outside the scope of the Wikimedia Foundation's Discovery Department, so I'm afraid I probably won't be able to help you.

Much better.

Solve the alignement.

Still remains the trailing \n at the end of the page.
You can see the result here http://www.jouvinio.net/wiki/index.php?title=Sp%C3%A9cial%3ARecherche&profile=default&search=Jenkins&fulltext=Search

For the remaining \n at the eand.

In the file SpecialSearch.php, I found this :
$out->addHTML( '<div class="visualClear"></div>\n' );

I removed the \n and it "fix" the display.
But I also saw this ;

if ( $prevnext ) {
        $out->addHTML( "<p class='mw-search-pager-bottom'>{$prevnext}</p>\n" );
}

So, may be it can be displayed in other case.

Ok, did not understand that the fix will comes with the next release.

Sorry about that.

Aklapper triaged this task as Lowest priority.Feb 16 2016, 3:09 PM
TheDJ closed this task as Resolved.EditedNov 4 2024, 7:18 PM
TheDJ claimed this task.
TheDJ subscribed.

This was resolved a long time ago (1.26.4). I tested it even today, and it looks ok

Screenshot 2024-11-04 at 20.16.51.png (1×2 px, 1 MB)

Screenshot 2024-11-04 at 20.16.45.png (1×2 px, 879 KB)