Page MenuHomePhabricator
Create Task
Maniphest T119923

Clicking the 'remove' button in the link context doesn't work if the cursor is at the beginning of the link text
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Open a page with VE which has link in it
  2. Place the cursor at the beginning of the link text
  3. Now click on the remove link icon

Observed Result:
It does not remove the link from the text.

Screen Shot 2015-11-30 at 4.25.01 PM.png (244×583 px, 22 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Annotation context items: expand the selection if no annotationsVisualEditor/VisualEditormaster+12 -0
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Dec 1 2015, 12:25 AM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 1 2015, 12:25 AM
Jdforrester-WMF renamed this task from Cannot remove link if the cursor is at the beginning of the link text to Clicking the 'remove' button in the link context doesn't work if the cursor is at the beginning of the link text.Dec 1 2015, 8:06 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF added projects: VisualEditor-Links, VisualEditor-ContentEditable.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Needs Discussion/Analysis on the VisualEditor board.
Jdforrester-WMF added subscribers: dchan, Jdforrester-WMF.Dec 3 2015, 2:41 AM

Delving into this, in ve.ui.AnnotationContextItem.prototype.onClearButtonClick, fragment is correct in both circumstances but fragment.getAnnotations( true ) doesn't return the right thing. I guess ve.dm.SurfaceFragment#getAnnotations needs to be updated to have a method of asking if it's "inside" or "outside" when at the start of a link/other 'cursored' annotation? @dchan?

DLynch subscribed.Dec 3 2015, 6:10 PM

Definitely has a conceptual relationship to T114376.

Jdforrester-WMF added a comment.Dec 3 2015, 6:11 PM
In T119923#1849103, @DLynch wrote:

Definitely has a conceptual relationship to T114376.

Indeed.

gerritbot subscribed.Dec 15 2015, 8:01 AM

Change 259216 had a related patch set uploaded (by DLynch):
Annotation context items: expand the selection if no annotations

https://gerrit.wikimedia.org/r/259216

gerritbot added a project: Patch-For-Review.Dec 15 2015, 8:01 AM
Esanders closed this task as Resolved.Dec 16 2015, 2:09 PM
Esanders claimed this task.
DLynch claimed this task.Dec 16 2015, 5:35 PM
DLynch removed a project: Patch-For-Review.
gerritbot added a comment.Dec 16 2015, 6:20 PM

Change 259216 merged by jenkins-bot:
Annotation context items: expand the selection if no annotations

https://gerrit.wikimedia.org/r/259216

Jdforrester-WMF added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Jan 3 2016, 3:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits