Some repos are using jshint and jsonlint Jenkins jobs as their main testing, whereas it would be better to use npm with jsonlint and eslint.
In the CI config t should be set out like:
template: - name: npm
We need to get a list of all repos that are using the jshint and jsonlint test.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | hashar | T119973 Convert all repos to use npm Jenkins job with jsonlint and eslint | |||
| Resolved | hashar | T144337 Standalone jshint check for ULS is failing | |||
| Declined | None | T155556 Send out email regarding removal of jshint and jsonlint tests | |||
| Resolved | hashar | T156678 mediawiki/extensions/UploadWizard "Basic test build" (non-whitelisted users) includes 'jshint', which fails on master, because we switched to eslint | |||
| Resolved | hashar | T163781 CiviCRM: lint json and php files using composer |
Change 273963 had a related patch set uploaded (by Paladox):
[AbuseFilter] Add npm test
Change 274800 had a related patch set uploaded (by Paladox):
Add npm entry point with jsonlint and banana checker tests
You're making good progress on this, so setting the assignee to you (feel free, of course, to undo that if you don't plan to work on it more).
@greg thanks yes, I'm going to work on it. It will be hard for non mw repos since they would like it set differently.
Change 274800 merged by jenkins-bot:
Add npm entry point with jsonlint and banana checker tests
Change 335800 had a related patch set uploaded (by Hashar):
Clean out usage of jshint/jsonlint/phplint
Change 335803 had a related patch set uploaded (by Hashar):
Remove check jobs from wikimedia/fundraising
Change 349439 had a related patch set uploaded (by Hashar):
[integration/config@master] Clean out jsonlint/jshint
I am sending 190 patches that adds grunt-contrib-jshint to MediaWiki extensions. See Gerrit topic:T119973.
And I'm going to have to C-1 all of them. :-( See T118941: Switch to eslint for our linting and our code styling in all Wikimedia JavaScript code.
I clarified the idea with James over IRC. The intent is to phase out the legacy Jenkins jobs that runs an outdated jshint version. The straightforward way is to migrate jshint from the hardcoded version on the CI nodes to package.json. This way I can phase out the old jobs quite easily.
So at least the outcome is that all extensions will have a job running npm test. That will benefit the migration to eslint.
Change 349439 merged by jenkins-bot:
[integration/config@master] Clean out jsonlint/jshint
The Jenkins job that runs jshint has been removed from all the repositories. They now solely run npm test and whatever developers have defined in their repo.
Change 350141 had a related patch set uploaded (by Hashar):
[wikimedia/wikimania-scholarships@master] build: jsonlint/jshint via npm
Change 350141 merged by jenkins-bot:
[wikimedia/wikimania-scholarships@master] build: jsonlint/jshint via npm
Change 350146 had a related patch set uploaded (by Hashar):
[integration/config@master] wikimedia/fundraising/tools: drop jshint/jsonlint
Change 350146 merged by jenkins-bot:
[integration/config@master] wikimedia/fundraising/tools: drop jshint/jsonlint
Change 350147 had a related patch set uploaded (by Hashar):
[integration/config@master] Remove all jshint references
Change 350148 had a related patch set uploaded (by Hashar):
[integration/jenkins@master] Remove jshint entirely
@Krinkle for info, CI no more uses the jshint version from integration/jenkins.git. All repositories have been migrated to use npm instead. JJB/Zuul/slave-scripts have been cleaned up.
Change 350148 merged by jenkins-bot:
[integration/jenkins@master] Remove jshint entirely
Change 350147 merged by jenkins-bot:
[integration/config@master] Remove all jshint references
Change 350152 had a related patch set uploaded (by Hashar):
[integration/config@master] Remove jsonlint from check pipeline
Change 350154 had a related patch set uploaded (by Hashar):
[integration/config@master] Remove 'jsonlint' job
Change 350152 merged by jenkins-bot:
[integration/config@master] Remove jsonlint from check pipeline
Change 350154 merged by jenkins-bot:
[integration/config@master] Remove 'jsonlint' job
Change 350160 had a related patch set uploaded (by Hashar):
[integration/config@master] Drop mwgate-jsonlint from some repositories
Change 350160 merged by jenkins-bot:
[integration/config@master] Drop mwgate-jsonlint from some repositories
Change 350166 had a related patch set uploaded (by Hashar):
[integration/config@master] Remove mwgate-jsonlint from mw-checks-test
Change 350166 merged by jenkins-bot:
[integration/config@master] Remove mwgate-jsonlint from mw-checks-test
Last job to migrated is wikimedia-fundraising-crm-jsonlint though that repo does not have a npm entry point at all. Tracked by T163781: CiviCRM: lint json and php files using composer.
Change 351187 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Remove all jsonlint references
Change 351188 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/jenkins@master] Remove jsonlint entirely
Change 351188 merged by jenkins-bot:
[integration/jenkins@master] Remove jsonlint entirely
The jobs taht ran an hardcoded/obsolete version of jshint and the one running a custom jsonlint, are now entirely removed from Jenkins and the CI infrastructure. They have been replaced by grunt-jsonlint and either grunt-contrib-jshint or grunt-eslint.
Change 351187 merged by jenkins-bot:
[integration/config@master] Remove all jsonlint references