Page MenuHomePhabricator

As a user setting up my language preferences for the first time, I want to be able to delete languages from the list
Closed, ResolvedPublic3 Estimated Story Points

Description

Because the language setup screen implemented in T114460 allows the user to re-order their languages but not delete them. This is because tables in iOS are usually not in "reorderable" and "deletable" states simultaneously. It will take a custom cell/UX if we want to add deletion to this screen.

There are two potential flows that are potentially ways to handle this:

  1. Table is re-orderable on first display (as mocked)
  2. User can swipe to delete items

Or:

  1. Table is re-orderable on first display (as mocked)
  2. User can press an "Delete" button, which would add a deletion decorator, tapping the decorator would remove the language (visually the iOS delete circle could be substituted in for the order numbers or the re-ordering indicator)
  3. The Delete button would be relabeled done and they can go back to the reordering state by pressing it

Next step is for @Fjalapeno to look at if there are easy ways to do either of these, and then we can implement or re-scope from there.

Event Timeline

JMinor raised the priority of this task from to Medium.
JMinor updated the task description. (Show Details)
MBinder_WMF set Security to None.
MBinder_WMF edited a custom field.

Checked with 5.0.0.551 on iPad mini iOS 8.2 (needs more testing on different devices - there is a small display bug)

  • Upon a clean installation, languages on this list are the languages that are in a device's Settings-General-Language & Region - Preferred Language Order
  • Languages can be re-ordered by dragging - all functionality seems to be working

IMG_0464.PNG (2×1 px, 89 KB)

IMG_0465.PNG (2×1 px, 88 KB)

  • Add 'afar' - the lang is not in iOS lang and, therefore, can be deleted from the list by swiping from right to left
  • Afar cannot be deleted later from the Languages screen

IMG_0466.PNG (2×1 px, 90 KB)

Checked with 5.0.0.558 on iPhone 6S+ 9.1 - 'Delete' looks better.

IMG_0027.PNG (2×1 px, 107 KB)