Page MenuHomePhabricator

CSS mw-graph-switch-button has duplicate attributes
Closed, ResolvedPublic

Description

styles/common.less contains duplicate padding and color values. Not sure which ones should be used:

position: absolute;
top: 0;
left: auto;
right: 0;
text-align: center;
background-color: lighten(@c-graph-main, 65%);
padding: 3px 10px;
font-size: 12px;
color: @colorGray5;
color: @c-graph-main;
font-weight: bold;
display: none;
border-radius: @borderRadius;
padding: .4em .8em;
border: 6px solid @colorWhite;

Details

Related Gerrit Patches:
mediawiki/extensions/Graph : masterSimplify HTML logic, fix dupl img+live

Event Timeline

Yurik created this task.Dec 3 2015, 5:17 PM
Yurik assigned this task to JGirault.
Yurik raised the priority of this task from to Needs Triage.
Yurik updated the task description. (Show Details)
Yurik added a subscriber: Yurik.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 3 2015, 5:17 PM

Change 256763 had a related patch set uploaded (by Yurik):
Simplify HTML logic, fix dupl img live

https://gerrit.wikimedia.org/r/256763

Yurik claimed this task.Dec 4 2015, 1:22 AM
Yurik set Security to None.

Change 256763 merged by jenkins-bot:
Simplify HTML logic, fix dupl img live

https://gerrit.wikimedia.org/r/256763

Yurik closed this task as Resolved.Dec 4 2015, 3:10 AM