Page MenuHomePhabricator

Fix "PHP Notice: Undefined property: stdClass::$detail in MathRestbaseInterface.php "
Closed, ResolvedPublic

Description

The following is outputted to the page:

Notice: Trying to get property of non-object in /var/www/MediaWiki/extensions/Math/MathRestbaseInterface.php on line 83

Notice: Undefined property: stdClass::$detail in /var/www/MediaWiki/extensions/Math/MathRestbaseInterface.php on line 84

Event Timeline

Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: Math.
Esanders added a subscriber: Esanders.

I also get an internal error if I disable restbase. The extension should probably work without restbase.

Krinkle renamed this task from Math extension throwing warnings to Fix "PHP Notice: Undefined property: stdClass::$detail in MathRestbaseInterface.php ".Dec 10 2015, 11:08 PM
Krinkle added a subscriber: Krinkle.

(the other one is tracked as T121165)

Esanders triaged this task as Unbreak Now! priority.Dec 10 2015, 11:26 PM

I don't understand how this code hopes to work in the world where makeRestbaseCheckRequest fails because the server's dead or not configured or Mathoid is down or…; what exactly is meant to return "details" and "error" if there's no response?