Page MenuHomePhabricator

CentralNotice: wrap LocalStorage access in try/catch to prevent errors on w/ cookies (& LS) disabled
Closed, ResolvedPublic

Description

If you select "Block sites from setting any data" in the Chrome settings, attempts to access the window.LocalSettings object throw an exception. The same thing happens in Firefox if you disable cookies.

Solution: Wrap all these in try/catch blocks.

Event Timeline

AndyRussG raised the priority of this task from to Needs Triage.
AndyRussG updated the task description. (Show Details)
AndyRussG moved this task to Triage on the Fundraising-Backlog board.
AndyRussG subscribed.
AndyRussG renamed this task from CentralNotice: wrap LocalStorage access in try/catch to prevent errors on Chrome w/ cookies & LS disabled to CentralNotice: wrap LocalStorage access in try/catch to prevent errors on w/ cookies (& LS) disabled.Dec 4 2015, 4:28 PM
AndyRussG updated the task description. (Show Details)
AndyRussG set Security to None.
AndyRussG updated the task description. (Show Details)
AndyRussG added a subscriber: Krinkle.