Page MenuHomePhabricator
Create Task
Maniphest T120388

Crash: NullPointerException in NearbyFragment.checkLocationPermissionsToGoToUserLocation()
Closed, ResolvedPublic
Actions

Description

https://rink.hockeyapp.net/manage/apps/226650/app_versions/6/crash_reasons/70618773

1 android.animation.PropertyValuesHolder.setupSetterAndGetter PropertyValuesHolder.java, line 513
2 android.animation.ObjectAnimator.initAnimation ObjectAnimator.java, line 385
3 android.animation.ValueAnimator.setCurrentPlayTime ValueAnimator.java, line 537
4 android.animation.ValueAnimator.start ValueAnimator.java, line 927
5 android.animation.ValueAnimator.start ValueAnimator.java, line 950
6 android.animation.ObjectAnimator.start ObjectAnimator.java, line 363
7 com.mapbox.mapboxsdk.views.UserLocationView.setLocation UserLocationView.java, line 401
8 com.mapbox.mapboxsdk.views.UserLocationView.toggleGps UserLocationView.java, line 300
9 com.mapbox.mapboxsdk.views.UserLocationView.setEnabled UserLocationView.java, line 230
10 com.mapbox.mapboxsdk.views.MapView.setMyLocationEnabled MapView.java, line 3122
11 org.wikipedia.nearby.NearbyFragment.checkLocationPermissionsToGoToUserLocation NearbyFragment.java, line 210
12 org.wikipedia.nearby.NearbyFragment.onActivityCreated NearbyFragment.java, line 107
13 android.support.v4.app.Fragment.performActivityCreated Fragment.java, line 1970

Details

SubjectRepoBranchLines +/-
Workaround Mapbox View ProGuard rulesapps/android/wikipediamaster+3 -4
Customize query in gerrit

Event Timeline

Dbrant created this task.Dec 4 2015, 5:17 PM
Dbrant raised the priority of this task from to High.
Dbrant updated the task description. (Show Details)
Dbrant added a project: Wikipedia-Android-App-Backlog.
Dbrant moved this task to Next Sprint on the Wikipedia-Android-App-Backlog board.
Dbrant subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 4 2015, 5:17 PM
• Niedzielski claimed this task.Dec 4 2015, 9:04 PM
• Niedzielski set Security to None.
gerritbot subscribed.Dec 5 2015, 3:46 AM

Change 257050 had a related patch set uploaded (by Niedzielski):
Workaround Mapbox View ProGuard rules

https://gerrit.wikimedia.org/r/257050

gerritbot added a project: Patch-For-Review.Dec 5 2015, 3:46 AM
• Niedzielski added a comment.Dec 5 2015, 3:47 AM

^^ Workaround fix. Real fix upstream[0]. I'm moving this issue to tracking until it's merged.

[0] https://github.com/mapbox/mapbox-gl-native/pull/3198

• Niedzielski moved this task from Next Sprint to Tracking on the Wikipedia-Android-App-Backlog board.Dec 5 2015, 3:49 AM
Dbrant added a project: Mobile-App-Android-Sprint-72-Hafnium.Dec 7 2015, 4:24 PM
Dbrant moved this task from To Do to Code Review on the Mobile-App-Android-Sprint-72-Hafnium board.
gerritbot added a comment.Dec 7 2015, 4:46 PM

Change 257050 merged by jenkins-bot:
Workaround Mapbox View ProGuard rules

https://gerrit.wikimedia.org/r/257050

Dbrant moved this task from Code Review to QA Signoff on the Mobile-App-Android-Sprint-72-Hafnium board.Dec 7 2015, 4:47 PM
Etonkovidova subscribed.Dec 8 2015, 12:24 AM

Checked with 2.1.135-alpha-2015-12-07 on Nexus 5 (Android 5.1.1)

Note: Probably unrelated - with Google settings-Location turned off, there is " An unknown error occured." message is displayed in Nearby.

Screenshot_2015-12-07-15-59-42.png (1×1 px, 89 KB)

Etonkovidova moved this task from QA Signoff to Ready for Signoff on the Mobile-App-Android-Sprint-72-Hafnium board.Dec 8 2015, 12:25 AM
• Niedzielski added a comment.Dec 11 2015, 5:20 AM

https://github.com/mapbox/mapbox-gl-native/pull/3198

Upstream patch merged. Might ship in v2.4.0.

@Etonkovidova, I'm not sure. This might be a different issue.

Dbrant moved this task from Ready for Signoff to Done on the Mobile-App-Android-Sprint-72-Hafnium board.Dec 14 2015, 7:24 PM
Dbrant closed this task as Resolved.Jan 4 2016, 5:44 PM
Dbrant moved this task from Tracking to Resolved/Invalid/Declined/Legacy on the Wikipedia-Android-App-Backlog board.Jan 18 2016, 3:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL