Page MenuHomePhabricator

extension.json schema does not allow doubles as values of config settings
Closed, ResolvedPublic

Description

					"type": ["object", "array", "string", "integer", "null", "boolean"],

is the current validation type list of "config" values. We need to set "number" instead of "integer". But since we accept every value, lets just get rid of the type check entirely.

This was noticed by the RelatedArticles extension, which has:

	"config": {
		"RelatedArticlesShowReadMore": false,
		"RelatedArticlesUseCirrusSearch": false,
		"RelatedArticlesOnlyUseCirrusSearch": false,
		"RelatedArticlesLoggingSamplingRate": 0.01
	},

Details

Related Gerrit Patches:

Event Timeline

Legoktm created this task.Dec 5 2015, 5:04 AM
Legoktm claimed this task.
Legoktm raised the priority of this task from to Medium.
Legoktm updated the task description. (Show Details)
Legoktm added a subscriber: Legoktm.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 5 2015, 5:04 AM

Change 257058 had a related patch set uploaded (by Legoktm):
registration: Remove type validation for "config" items

https://gerrit.wikimedia.org/r/257058

Change 257058 merged by jenkins-bot:
registration: Remove type validation for "config" items

https://gerrit.wikimedia.org/r/257058

Legoktm closed this task as Resolved.Dec 5 2015, 11:23 PM