Maniphest T120507

extension.json schema does not allow doubles as values of config settings
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Dec 5 2015, 5:04 AM

Description

					"type": ["object", "array", "string", "integer", "null", "boolean"],

is the current validation type list of "config" values. We need to set "number" instead of "integer". But since we accept every value, lets just get rid of the type check entirely.

This was noticed by the RelatedArticles extension, which has:

	"config": {
		"RelatedArticlesShowReadMore": false,
		"RelatedArticlesUseCirrusSearch": false,
		"RelatedArticlesOnlyUseCirrusSearch": false,
		"RelatedArticlesLoggingSamplingRate": 0.01
	},

Details

	Subject	Repo	Branch	Lines +/-
	registration: Remove type validation for "config" items	mediawiki/core	master	+0 -1

Customize query in gerrit

Event Timeline

Legoktm created this task.Dec 5 2015, 5:04 AM

Legoktm claimed this task.

Legoktm raised the priority of this task from to Medium.

Legoktm updated the task description. (Show Details)

Legoktm added a project: MediaWiki-Configuration.

Legoktm subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 5 2015, 5:04 AM

Change 257058 had a related patch set uploaded (by Legoktm):
registration: Remove type validation for "config" items

https://gerrit.wikimedia.org/r/257058

gerritbot added a project: Patch-For-Review.Dec 5 2015, 5:04 AM

Change 257058 merged by jenkins-bot:
registration: Remove type validation for "config" items

https://gerrit.wikimedia.org/r/257058

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), MW-1.27-release-notes.Dec 5 2015, 10:00 PM

Legoktm closed this task as Resolved.Dec 5 2015, 11:23 PM

extension.json schema does not allow doubles as values of config settingsClosed, ResolvedPublicActions

Description

Details

Event Timeline

extension.json schema does not allow doubles as values of config settings
Closed, ResolvedPublic
Actions