Core code should not be aware of node names
Open, LowPublic8 Story Points


In a couple of places we check things like:

if ( node.getName() === 'listItem' ) { // Foobar the node }

These should be replaced with feature checks on the node:

if ( node.isFoobarable() ) { }

to maintain separation between core code and registered nodes, and also to make sure we don't need to update all those conditionals when new nodes are registered, e.g.

if ( node.getName() === 'listItem' || node.getName() === 'definitionListItem' ) { }
Esanders created this task.Dec 7 2015, 12:56 PM
Esanders updated the task description. (Show Details)
Esanders raised the priority of this task from to Needs Triage.
Esanders added subscribers: Esanders, DLynch, dchan.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 7 2015, 12:56 PM
Krenair added a subscriber: Krenair.Dec 7 2015, 1:06 PM
Jdforrester-WMF triaged this task as Low priority.Dec 8 2015, 8:10 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Backlog on the VisualEditor board.