Page MenuHomePhabricator
Create Task
Maniphest T120653

Allow ve.ui.MediaSizeWidget to take a plain dimensions widget
Closed, ResolvedPublic1 Estimated Story Points
Actions

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make MediaSizeWidget work without default/original dimensionsVisualEditor/VisualEditormaster+22 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Dec 7 2015, 1:09 PM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added projects: VisualEditor, Technical-Debt.
Esanders subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 7 2015, 1:09 PM
Esanders added a parent task: T119261: While using the resize handler on a graph, the lowest limit for resizing is 60x60px, but not when resizing from dialog.Dec 7 2015, 1:09 PM
Esanders added a comment.Dec 7 2015, 2:04 PM

Actually we should generalize MediaSizeWidget to work more like a plain dimensions widget in some cases

gerritbot subscribed.Dec 7 2015, 2:06 PM

Change 257314 had a related patch set uploaded (by Esanders):
Make MediaSizeWidget work without default/original dimensions

https://gerrit.wikimedia.org/r/257314

gerritbot added a project: Patch-For-Review.Dec 7 2015, 2:06 PM
gerritbot added a comment.Dec 7 2015, 4:41 PM

Change 257314 merged by jenkins-bot:
Make MediaSizeWidget work without default/original dimensions

https://gerrit.wikimedia.org/r/257314

Jdforrester-WMF renamed this task from Allow ve.ui.DimensionsWidgets to take a ve.dm.Scalable object to restrict dimensions to Allow ve.ui.MediaSizeWidget to take a plain dimensions widget.Dec 7 2015, 4:46 PM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF edited projects, added: MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)); removed: Patch-For-Review.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.Dec 8 2015, 7:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits