Page MenuHomePhabricator
Create Task
Maniphest T120698

CentralNotice: impression diet and hide cookies interaction bug causes hidden impression counting for impression diet
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

If a user clicks to hide a banner in a campaign with the impression diet feature enabled, that feature counts subsequent pageviews where a banner was hidden as if a banner has been shown.

This affects pageview counts for users in the Big English campaign. Let's include in this task any measures to remedy that. :)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
impressionDiet: don't count impressions if banner hidden by close cookiemediawiki/extensions/CentralNoticewmf_deploy+19 -12
impressionDiet: don't count impressions if banner hidden by close cookiemediawiki/extensions/CentralNoticemaster+19 -12
Customize query in gerrit

Event Timeline

• AndyRussG created this task.Dec 7 2015, 7:32 PM
• AndyRussG claimed this task.
• AndyRussG raised the priority of this task from to Needs Triage.
• AndyRussG updated the task description. (Show Details)
• AndyRussG added projects: Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Fundraising Sprint Yo La Tengo.
• AndyRussG moved this task to Current Sprint & Completed in Q4 1516 on the Fundraising-Backlog board.
• AndyRussG subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 7 2015, 7:32 PM
• AndyRussG set Security to None.Dec 7 2015, 7:32 PM
• AndyRussG edited a custom field.
• AndyRussG moved this task from Backlog to Doing on the Fundraising Sprint Yo La Tengo board.
gerritbot subscribed.Dec 7 2015, 11:03 PM

Change 257497 had a related patch set uploaded (by AndyRussG):
impressionDiet: don't count impressions if banner hidden by close cookie

https://gerrit.wikimedia.org/r/257497

gerritbot added a project: Patch-For-Review.Dec 7 2015, 11:03 PM
• AndyRussG moved this task from Doing to Review on the Fundraising Sprint Yo La Tengo board.Dec 7 2015, 11:50 PM
gerritbot added a comment.Dec 8 2015, 12:13 AM

Change 257497 merged by jenkins-bot:
impressionDiet: don't count impressions if banner hidden by close cookie

https://gerrit.wikimedia.org/r/257497

• AndyRussG moved this task from Review to Pending Deployment on the Fundraising Sprint Yo La Tengo board.Dec 8 2015, 12:23 AM
gerritbot added a comment.Dec 8 2015, 3:44 PM

Change 257614 had a related patch set uploaded (by AndyRussG):
impressionDiet: don't count impressions if banner hidden by close cookie

https://gerrit.wikimedia.org/r/257614

gerritbot added a comment.Dec 8 2015, 3:47 PM

Change 257614 merged by jenkins-bot:
impressionDiet: don't count impressions if banner hidden by close cookie

https://gerrit.wikimedia.org/r/257614

• DStrine moved this task from Current Sprint & Completed in Q4 1516 to Closed Sprint Work Completed in Q2 1516 on the Fundraising-Backlog board.Dec 8 2015, 5:14 PM
• AndyRussG moved this task from Pending Deployment to Done on the Fundraising Sprint Yo La Tengo board.Dec 8 2015, 5:22 PM
• AndyRussG closed this task as Resolved.Dec 9 2015, 11:37 PM
• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits