Page MenuHomePhabricator

CentralNotice: impression diet and hide cookies interaction bug causes hidden impression counting for impression diet
Closed, ResolvedPublic1 Story Points

Description

If a user clicks to hide a banner in a campaign with the impression diet feature enabled, that feature counts subsequent pageviews where a banner was hidden as if a banner has been shown.

This affects pageview counts for users in the Big English campaign. Let's include in this task any measures to remedy that. :)

Event Timeline

AndyRussG created this task.Dec 7 2015, 7:32 PM
AndyRussG updated the task description. (Show Details)
AndyRussG raised the priority of this task from to Needs Triage.
AndyRussG claimed this task.
AndyRussG added a subscriber: AndyRussG.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 7 2015, 7:32 PM
AndyRussG set Security to None.Dec 7 2015, 7:32 PM
AndyRussG edited a custom field.
AndyRussG moved this task from Backlog to Doing on the Fundraising Sprint Yo La Tengo board.

Change 257497 had a related patch set uploaded (by AndyRussG):
impressionDiet: don't count impressions if banner hidden by close cookie

https://gerrit.wikimedia.org/r/257497

Change 257497 merged by jenkins-bot:
impressionDiet: don't count impressions if banner hidden by close cookie

https://gerrit.wikimedia.org/r/257497

Change 257614 had a related patch set uploaded (by AndyRussG):
impressionDiet: don't count impressions if banner hidden by close cookie

https://gerrit.wikimedia.org/r/257614

Change 257614 merged by jenkins-bot:
impressionDiet: don't count impressions if banner hidden by close cookie

https://gerrit.wikimedia.org/r/257614

AndyRussG closed this task as Resolved.Dec 9 2015, 11:37 PM