Page MenuHomePhabricator
Create Task
Maniphest T120707

Graphs are overlapping with next line in readmode
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Insert a graph
  2. Insert anything after that graph text/ any focusable node/ another graph
  3. Save the page

Observed Result:
In read mode the graph is overlapping with next line

Screen Shot 2015-12-07 at 11.37.46 AM.png (419×489 px, 29 KB)

Screen Shot 2015-12-07 at 11.47.42 AM.png (275×516 px, 20 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix graphs overlapping with next line in readmodemediawiki/extensions/Graphwmf/1.27.0-wmf.8+1 -1
Fix graphs overlapping with next line in readmodemediawiki/extensions/Graphmaster+1 -1
Customize query in gerrit

Event Timeline

Ryasmeen created this task.Dec 7 2015, 7:49 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added projects: VisualEditor, Graph-VisualEditor.
Ryasmeen subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 7 2015, 7:49 PM
Ryasmeen added a project: MediaWiki-extensions-Graph.Dec 7 2015, 7:52 PM
Ryasmeen set Security to None.
Jdforrester-WMF triaged this task as High priority.Dec 8 2015, 8:12 PM
Jdforrester-WMF removed projects: Graph-VisualEditor, VisualEditor.
Jdforrester-WMF added subscribers: Yurik, • ferdbold.
Jdforrester-WMF subscribed.

Maybe we should add some larger padding around each?

Yurik added a subscriber: • JGirault.Dec 8 2015, 8:14 PM
Yurik added a comment.Dec 8 2015, 8:25 PM

Should each graph behave like a "large character"? This way the regular spacing between the lines would apply to it as well? I'm not a CSS expert though.

gerritbot subscribed.Dec 9 2015, 12:50 AM

Change 257797 had a related patch set uploaded (by JGirault):
Fix graphs overlapping with next line in readmode

https://gerrit.wikimedia.org/r/257797

gerritbot added a project: Patch-For-Review.Dec 9 2015, 12:50 AM
gerritbot added a comment.Dec 9 2015, 12:56 AM

Change 257797 merged by jenkins-bot:
Fix graphs overlapping with next line in readmode

https://gerrit.wikimedia.org/r/257797

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Dec 9 2015, 1:00 AM
gerritbot added a comment.Dec 9 2015, 1:46 AM

Change 257810 had a related patch set uploaded (by Catrope):
Fix graphs overlapping with next line in readmode

https://gerrit.wikimedia.org/r/257810

gerritbot added a comment.Dec 9 2015, 1:47 AM

Change 257810 merged by jenkins-bot:
Fix graphs overlapping with next line in readmode

https://gerrit.wikimedia.org/r/257810

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)).Dec 9 2015, 2:00 AM
Ryasmeen closed this task as Resolved.Dec 14 2015, 10:01 PM
Ryasmeen added a project: Verified.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits