Page MenuHomePhabricator
Create Task
Maniphest T120923

Ask for consensus to enable and deploy ORES extension to production
Closed, ResolvedPublic
Actions

Description

This task is complete when the ORES extension is enabled and available on a Wikimedia project.

Primary users: patroller, watchlist user

Needs:

  • Quickly review Special:RecentChanges for damage
  • Quickly review Special:Watchlist activity for damage (T122535)
  • Quickly review Special:Contributions for damage (T122537)

Features:

  1. Special:RecentChanges
    1. Edits in RecentChanges that are likely to be damaging are flagged for review,
    2. Edits in RecentChanges that are not likely to be damaging can be filtered out of the list
  2. Special:Contributions
    1. Edits in Contributions that are likely to be damaging are flagged for review
    2. Edits in Contributions that are not likely to be damaging can be filtered out of the list
  3. Special:Watchlist
    1. Edits in Watchlist that are likely to be damaging are flagged for review
    2. Edits in Watchlist that are not likely to be damaging can be filtered out of the list.

Proposed implementation:

  • Roughly replicate the functionality of gadget-ScoredRevisions
  • Cache scores so we can efficiently join when filtering feeds.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add ORES to whitelisted beta features.operations/mediawiki-configmaster+1 -0
Enable ORES on fawikioperations/mediawiki-configmaster+27 -0
Add ORES to extension-listoperations/mediawiki-configmaster+1 -0
Branch ORES for WMF deploymentsmediawiki/tools/releasemaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

awight created this task.Dec 9 2015, 10:25 AM
awight raised the priority of this task from to Needs Triage.
awight updated the task description. (Show Details)
awight added a project: Machine-Learning-Team (Active Tasks).
awight subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 9 2015, 10:25 AM
awight added a subtask: T112856: Write prototype MediaWiki extension to surface ORES scores.Dec 9 2015, 10:25 AM
awight added a subtask: T121589: mw-ext-ORES should play nice with patrol flags.Dec 15 2015, 11:08 PM
He7d3r subscribed.Dec 16 2015, 4:20 PM
Halfak updated the task description. (Show Details)Dec 17 2015, 3:39 PM
Halfak set Security to None.
Ladsgroup subscribed.Dec 17 2015, 3:46 PM
awight closed subtask T112856: Write prototype MediaWiki extension to surface ORES scores as Resolved.Dec 28 2015, 11:09 PM
awight added a subscriber: Halfak.Dec 28 2015, 11:27 PM

@Halfak
Thanks for writing this design spec!

awight updated the task description. (Show Details)Dec 28 2015, 11:30 PM
Aklapper added a comment.Dec 29 2015, 1:24 AM

For the actual deployment request, please see https://www.mediawiki.org/wiki/Review_queue#Checklist

Ladsgroup added a project: MediaWiki-extensions-ORES.Dec 30 2015, 9:39 PM
awight added a subtask: T120922: Security review of the ORES extension.Dec 30 2015, 9:56 PM
Ladsgroup updated the task description. (Show Details)Dec 30 2015, 11:00 PM
Anomie subscribed.Jan 2 2016, 5:52 PM

Shouldn't this be blocked by T106867: [Epic] Deploy Revscoring/ORES service in Prod?

Ladsgroup added subtasks: T122684: People should be able to change threshold of ORES in their preferences , T122766: ORES "r" flag doesn't work when grouping in recent changes is disabled.Jan 15 2016, 9:45 PM
Ladsgroup added a subtask: T123795: ORES extension tables should be able to be populated using maintenance scripts .Jan 15 2016, 9:50 PM
awight closed subtask T121589: mw-ext-ORES should play nice with patrol flags as Resolved.Jan 17 2016, 4:48 PM
awight added a project: Community-consensus-needed.
awight closed subtask T122535: Integrate ORES extension with Special:Watchlist as Resolved.
He7d3r renamed this task from Deploy ORES extension to production and ask for consensus to enable to Ask for consensus to enable and deploy ORES extension to production.Jan 19 2016, 12:35 PM
Halfak closed subtask T122766: ORES "r" flag doesn't work when grouping in recent changes is disabled as Resolved.Jan 21 2016, 3:44 PM
Lydia_Pintscher subscribed.Jan 22 2016, 1:22 PM

I can handle this for you for Wikidata when it's ready.

Halfak added a comment.Jan 22 2016, 2:50 PM

Excellent. That help will be very much appreciated. :)

awight closed subtask T123795: ORES extension tables should be able to be populated using maintenance scripts as Declined.Jan 27 2016, 3:57 AM
awight reopened subtask T123795: ORES extension tables should be able to be populated using maintenance scripts as Open.Jan 27 2016, 9:15 AM
Ladsgroup added a comment.Jan 31 2016, 9:21 AM

We have consensuses ready for deploying it in fa.wp. Here. We are almost good to go :)

Ladsgroup removed a subtask: T122537: Templatize Special:Contributions lines and add proper hooks.Jan 31 2016, 9:21 AM
Ladsgroup closed subtask T122684: People should be able to change threshold of ORES in their preferences as Resolved.Feb 2 2016, 12:29 PM
Reedy closed subtask T120922: Security review of the ORES extension as Resolved.Feb 9 2016, 8:02 PM
gerritbot subscribed.Feb 9 2016, 8:08 PM

Change 269476 had a related patch set uploaded (by Reedy):
Branch ORES for WMF deployments

https://gerrit.wikimedia.org/r/269476

gerritbot added a project: Patch-For-Review.Feb 9 2016, 8:08 PM
gerritbot added a comment.Feb 9 2016, 8:20 PM

Change 269478 had a related patch set uploaded (by Reedy):
[WIP] Enable ORES on fawiki

https://gerrit.wikimedia.org/r/269478

gerritbot added a comment.Feb 9 2016, 8:21 PM

Change 269476 merged by jenkins-bot:
Branch ORES for WMF deployments

https://gerrit.wikimedia.org/r/269476

greg subscribed.Feb 9 2016, 8:23 PM

Just checking here:
The deploy of Extension:ORES will depend on a WMF Labs service? Has this been reviewed by anyone in Ops?

greg added a comment.Feb 9 2016, 8:27 PM
In T120923#1912770, @Anomie wrote:

Shouldn't this be blocked by T106867: [Epic] Deploy Revscoring/ORES service in Prod?

I see Brad already asked this. I would greatly greatly greatly greatly prefer to have ORES in production and not depend on WMF Labs. We've seen two types of fall out from dependencies on Labs.

  1. The usage of the new feature is so much that even the number of requests going Labs brings it down (we had a bit of js loaded on pageviews that did this)
  2. WMF Labs has a hiccup causing the production consumer to fail in bad ways.

How is this being planned for and mitigated in this setup? Also, for the record, we pretty clearly block such cross prod/labs dependencies on the surface, so very good reasons/mitigations are needed.

Halfak added subscribers: yuvipanda, akosiaris.Feb 9 2016, 8:49 PM

@greg fair points. I'll follow advisement from ops here. @akosiaris is working on our production systems now. See T106867

@yuvipanda can help with discussions about what is at risk for Labs. FWIW, we're operating at a relatively high capacity at the moment and the system is robust and scale-able. fawiki is a good test case for us since there are few active editors and many of them are already using a tool that queries ORES (in a less efficient way than the extension would).

@akosiaris & @yuvipanda, what do you advise? Should we continue deploying the extension as a beta feature to fawiki while the ORES service is in labs or should we wait until the ORES service can be brought online in "prod"?

Ladsgroup added a comment.Feb 9 2016, 8:58 PM

As a developer of the extension I need to add that this extension depends on Labs services but when the service is down, no harm would happen to the wiki. Only edits made at the time span wouldn't have their scores stored in the ores_classification table, which means we need to run a maintenance script once a while (the patch of the maintenance script is about to be merged, I'm waiting for some inputs of sysadmins. See T123795)

Ladsgroup added a comment.Feb 10 2016, 4:23 PM

I just excluded bot edits which reduce the number of requests by 55% for fa.wp. Based on the RC table, this extension would call 1.7 times per minute (for fa.wp) once enabled. I think ores in wmflabs can handle that ;)
I must say: I just giving numbers, I wait for Ops to elaborate more.

Ladsgroup closed subtask T123795: ORES extension tables should be able to be populated using maintenance scripts as Resolved.Feb 16 2016, 6:33 PM
Legoktm subscribed.Feb 21 2016, 7:47 PM

It is not technically possible to deploy this extension before ORES is in production, as production cannot talk to *.wmflabs.org domains.

Legoktm created subtask T127661: Deploy ORES extension to beta cluster.Feb 21 2016, 7:50 PM
Legoktm closed subtask T127661: Deploy ORES extension to beta cluster as Resolved.Feb 24 2016, 7:59 PM
Ladsgroup moved this task from Backlog to Prioritized on the MediaWiki-extensions-ORES board.Mar 16 2016, 9:25 PM
Halfak edited projects, added Machine-Learning-Team; removed Machine-Learning-Team (Active Tasks).Mar 30 2016, 2:54 PM
Halfak added a comment.Mar 30 2016, 3:10 PM

@Ladsgroup, it looks like this task might be done since we have consensus for how to do it -- now we're *doing* it.

Halfak moved this task from Unsorted to Blocked on community input on the Machine-Learning-Team board.Mar 30 2016, 3:10 PM
Danny_B moved this task from Unsorted to All WMF wikis on the Community-consensus-needed board.Apr 29 2016, 8:52 AM
gerritbot added a comment.Jun 13 2016, 6:42 AM

Change 294027 had a related patch set uploaded (by Ladsgroup):
Add ORES to extension-list

https://gerrit.wikimedia.org/r/294027

gerritbot added a comment.Jun 13 2016, 3:45 PM

Change 294027 merged by jenkins-bot:
Add ORES to extension-list

https://gerrit.wikimedia.org/r/294027

gerritbot added a comment.Jun 13 2016, 3:48 PM

Change 269478 merged by jenkins-bot:
Enable ORES on fawiki

https://gerrit.wikimedia.org/r/269478

gerritbot added a comment.Jun 13 2016, 6:20 PM

Change 294103 had a related patch set uploaded (by Ladsgroup):
Add ORES to whitelisted beta features.

https://gerrit.wikimedia.org/r/294103

gerritbot added a comment.Jun 13 2016, 11:46 PM

Change 294103 merged by jenkins-bot:
Add ORES to whitelisted beta features.

https://gerrit.wikimedia.org/r/294103

Ladsgroup closed this task as Resolved.Jul 4 2016, 2:03 AM
Ladsgroup edited projects, added Machine-Learning-Team (Active Tasks); removed Machine-Learning-Team.
• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 6:45 PM
awight moved this task from Parked to Completed on the Machine-Learning-Team (Active Tasks) board.Jun 28 2017, 8:41 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits