Maniphest T1210

SHA-1 file name support
Closed, ResolvedPublic
Actions

Description

Mark T was interested in finally getting this merged. Not much is left to do on this anyway.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+1 K -93	Support for storing files under SHA-1 names

Customize query in gerrit

Related Objects

Mentioned In: rMWf1e1313a164a: Support for storing files under SHA-1 names
T96384: Integrate file revisions with description page history
T66214: Define an official thumb API
Mentioned Here: T3780: Can't upload file with non-ASCII name (eg cyrillic) on Windows host

Event Timeline

aaron created this task.Nov 10 2014, 8:31 PM

aaron raised the priority of this task from to Needs Triage.

aaron updated the task description. (Show Details)

aaron added a project: MediaWiki-Core-Team.

aaron moved this task to Needs Review/Feedback on the MediaWiki-Core-Team board.

aaron changed Security from none to None.

aaron added a subscriber: aaron.

aaron claimed this task.Nov 10 2014, 8:42 PM

Liuxinyu970226 added a subscriber: Liuxinyu970226.Nov 15 2014, 1:18 AM

https://gerrit.wikimedia.org/r/#/c/127460/

aaron renamed this task from Get gerrit change #127460 merged to SHA-1 file name support.Nov 17 2014, 10:10 PM

revi added a project: Patch-For-Review.Nov 25 2014, 4:48 AM

revi added a subscriber: revi.

• Gilles triaged this task as Medium priority.Nov 26 2014, 4:34 PM

• Gilles added a project: Multimedia.

• Gilles moved this task from Untriaged to Next up on the Multimedia board.

• Gilles added a subscriber: • Gilles.

• Gilles merged a task: T77651: Review SHA-1 patch.Dec 8 2014, 6:16 PM

• Gilles added subscribers: Aklapper, MingleTerminator.

• Gilles merged a task: T77651: Review SHA-1 patch.Dec 8 2014, 11:45 PM

• Gilles merged a task: T77886: Review & work SHA-1 changeset.Dec 8 2014, 11:51 PM

Just to get a sense of where we're at @aaron, now that I finally have time to look at this. Do you think we have bad/insufficient/ok/good test coverage for this change?

In particular I wonder if it would be useful to test specifically what happens when going from a repo working the old way to turning this on, because I'm not sure that we are currently.

Change 127460 had a related patch set uploaded (by Gilles):
Support for storing files under SHA-1 names

https://gerrit.wikimedia.org/r/127460

Patch-For-Review

• RobLa-WMF merged a task: T1115: Review change 127460.Dec 15 2014, 9:50 PM

Tgr mentioned this in T66214: Define an official thumb API.Dec 30 2014, 12:39 AM

aaron changed the task status from Open to Stalled.Jan 20 2015, 10:24 PM

aaron moved this task from Needs Review/Feedback to Backlog on the MediaWiki-Core-Team board.Feb 4 2015, 5:20 PM

• Gilles added a project: Multimedia-Sprint-2015-03-04.Mar 10 2015, 1:03 PM

• Gilles edited projects, added Multimedia-Sprint-2015-03-11; removed Multimedia-Sprint-2015-03-04.Mar 11 2015, 4:22 PM

• Gilles moved this task from Backlog to Needs code review on the Multimedia-Sprint-2015-03-11 board.Mar 11 2015, 4:25 PM

• Gilles edited projects, added Multimedia-Sprint-2015-03-18; removed Multimedia-Sprint-2015-03-11.Mar 18 2015, 4:14 PM

• Gilles moved this task from Backlog to Needs code review on the Multimedia-Sprint-2015-03-18 board.

• Gilles moved this task from Next up to Untriaged on the Multimedia board.Mar 23 2015, 8:55 AM

• Gilles edited projects, added Multimedia-Sprint-2015-03-25; removed Multimedia-Sprint-2015-03-18.Mar 25 2015, 3:44 PM

• Gilles moved this task from Backlog to Needs code review on the Multimedia-Sprint-2015-03-25 board.Mar 25 2015, 3:48 PM

• GWicke mentioned this in T96384: Integrate file revisions with description page history.May 11 2015, 8:34 PM

Krinkle edited projects, added MediaWiki-File-management; removed MediaWiki-Core-Team.May 15 2015, 2:46 PM

Change 127460 merged by Gilles:
Support for storing files under SHA-1 names

https://gerrit.wikimedia.org/r/127460

Restricted Application added a subscriber: Matanya. · View Herald TranscriptJul 21 2015, 5:55 PM

• Gilles mentioned this in rMWf1e1313a164a: Support for storing files under SHA-1 names.Jul 21 2015, 5:55 PM

Forrestbot added projects: MW-1.26-release, WMF-deploy-2015-07-21_(1.26wmf15).Jul 21 2015, 6:00 PM

McZusatz added a subscriber: McZusatz.Jul 21 2015, 6:19 PM

This is a blocker of T3780, right?

Performance cleanups (like img_auth/thumb.php) can go in separate bugs if needed.

Restricted Application added a subscriber: Steinsplitter. · View Herald TranscriptAug 6 2015, 7:46 PM

Liuxinyu970226 removed a subscriber: Liuxinyu970226.Aug 6 2015, 11:06 PM

No documentation and no RELEASE NOTES? sigh...