Page MenuHomePhabricator
Create Task
Maniphest T121017

When cursor is in an invalid position, cancelling the save dialog ("Resume") will cause a fatal as it tries to re-insert the cursor in a wrong place
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

With VisualEditor on the page https://test2.wikipedia.org/w/index.php?title=Drong-8&oldid=161646

Put the prompt just after (à tester)
delete with successives backspace (à tester) up to the prompt disappears next to website (don't touch website - official website stays not highlight)

Then Save page
Then Resume editing

Then the wizard is completely blocked (and the page)

MAC OS 10.11.1 - Safari 9.0.1/Chrome 46.0 Reproductible : always

This bug was initially posted on T119780 but impacted by a delete/restore process, he's now involved in a completely different issue

Related Objects

Event Timeline

Drongou created this task.Dec 9 2015, 9:44 PM
Drongou raised the priority of this task from to Needs Triage.
Drongou updated the task description. (Show Details)
Drongou subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 9 2015, 9:44 PM
Catrope added a project: VisualEditor.Dec 9 2015, 9:45 PM
Catrope set Security to None.
Krenair subscribed.Dec 9 2015, 10:19 PM

I do see weird cursor behaviour, but it doesn't break the resume editing button for me.

Drongou added a comment.Dec 10 2015, 1:40 PM

You have to stop just when the prompt disappears

Works with Chrome 47.0 / Windows 7 Reproductible : always

Drongou added a comment.Dec 10 2015, 5:57 PM

I mean : The bugs is always reproductible with Chrome 47.0 / Windows 7

Krenair added a subscriber: dchan.Dec 10 2015, 7:34 PM

Just reproduced it on Chrome 46 (on Ubuntu 15.10)
Uncaught Error: Offset could not be translated to a DOM element and offset: 21

Jdforrester-WMF renamed this task from Wait unlimited on Resume editing button (in a certain context) to When cursor is in an invalid position, cancelling the save dialog ("Resume") will cause a fatal as it tries to re-insert the cursor in a wrong place.Dec 10 2015, 7:38 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF added projects: VisualEditor-ContentEditable, VisualEditor-MediaWiki.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF subscribed.

OK, yup. The cursor should never get into this wrong position, but when it does, we should wrap the re-focussing of the document in a try/catch or something and default to (I guess) position 1.

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Dec 11 2015, 1:56 AM
• AlexMonk-WMF subscribed.Feb 23 2016, 7:46 PM
• AlexMonk-WMF removed a subscriber: Krenair.Feb 23 2016, 7:49 PM
• Deskana closed this task as Resolved.Sep 20 2017, 12:49 PM
• Deskana claimed this task.
• Deskana subscribed.

This seems to have been fixed at some point. The cursor seems to end up in an invalid position, but when you start typing again, it does what you'd expect it to with no freezes.

Screen Shot 2017-09-20 at 13.47.01.png (2,152×192 px, 36 KB)

Hey cursor, why are you all the way over there to the right? That's not where you live.

Screen Shot 2017-09-20 at 13.47.54.png (718×206 px, 33 KB)

After hitting "Publish changes", then "Resume editing", then typing something, the cursor moves back to where you'd expect and what you type also appears where you'd expect it to.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 20 2017, 12:49 PM
Jdforrester-WMF changed the point value for this task from 1 to 8.Sep 26 2017, 3:03 PM
Jdforrester-WMF changed the point value for this task from 8 to 1.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits