Page MenuHomePhabricator
Create Task
Maniphest T121069

Have PageAssessments do all database writes via the Job Queue
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

In order to prevent overloading the master database when we add the PageAssessments parser function to several million articles, we should queue the queries in the Job Queue. See https://www.mediawiki.org/wiki/Manual:Job_queue/For_developers. This is also just good practice for low-priority database writes.

Details

SubjectRepoBranchLines +/-
Submit updates via the job queue for PageAssessmentsmediawiki/extensions/PageAssessmentsmaster+79 -9
[WIP] Do all DB writes via the JobQueuemediawiki/extensions/PageAssessmentsmaster+104 -60
Customize query in gerrit

Related Objects
Search...

Event Timeline

kaldari created this task.Dec 10 2015, 4:38 AM
kaldari raised the priority of this task from to Needs Triage.
kaldari updated the task description. (Show Details)
kaldari subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 10 2015, 4:38 AM
kaldari triaged this task as Medium priority.Dec 10 2015, 4:40 AM
kaldari added a subtask: T121068: Have PageAssessments store all the assessments in ExtensionData until the page is finished parsing.
kaldari added a project: Community-Tech.
kaldari set Security to None.
kaldari moved this task from New & TBD Tickets to Up Next (June 3-21) on the Community-Tech board.
kaldari added a subscriber: Niharika.Dec 10 2015, 4:42 AM
• DannyH edited projects, added Community-Tech-Sprint; removed Community-Tech.Dec 10 2015, 6:18 PM
• DannyH added a project: WikiProject-tools.Dec 10 2015, 6:20 PM
• DannyH edited a custom field.
Niharika claimed this task.Dec 11 2015, 1:48 PM
Niharika moved this task from Ready to In Development on the Community-Tech-Sprint board.
gerritbot subscribed.Dec 14 2015, 4:04 PM

Change 258992 had a related patch set uploaded (by Niharika29):
[WIP] Do all DB writes via the JobQueue

https://gerrit.wikimedia.org/r/258992

gerritbot added a project: Patch-For-Review.Dec 14 2015, 4:04 PM
gerritbot added a comment.Dec 15 2015, 12:23 AM

Change 258992 abandoned by Kaldari:
[WIP] Do all DB writes via the JobQueue

Reason:
need to reimport from scratch per https://phabricator.wikimedia.org/T121157

https://gerrit.wikimedia.org/r/258992

gerritbot added a comment.Dec 15 2015, 1:53 AM

Change 258992 restored by Kaldari:
[WIP] Do all DB writes via the JobQueue

Reason:
Doesn't seem to make much difference re the force reset.

https://gerrit.wikimedia.org/r/258992

kaldari mentioned this in T117142: Create an extension for storing WikiProject article assessment metadata in a database table via a parser function.Dec 19 2015, 12:26 AM
• DannyH closed subtask T121068: Have PageAssessments store all the assessments in ExtensionData until the page is finished parsing as Resolved.Jan 11 2016, 9:31 PM
gerritbot added a comment.Jan 12 2016, 2:08 AM

Change 263572 had a related patch set uploaded (by Niharika29):
Submit updates via the job queue for PageAssessments

https://gerrit.wikimedia.org/r/263572

gerritbot added a comment.Jan 12 2016, 2:11 AM

Change 258992 abandoned by Niharika29:
[WIP] Do all DB writes via the JobQueue

Reason:
Made a new change as rebasing this re-created the files from BoilerPlate extension

https://gerrit.wikimedia.org/r/258992

Niharika moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Jan 12 2016, 2:13 AM
kaldari moved this task from Needs Review/Feedback to In Development on the Community-Tech-Sprint board.Jan 13 2016, 4:45 PM
kaldari moved this task from In Development to Q3 2018-19 on the Community-Tech-Sprint board.Jan 13 2016, 11:19 PM
gerritbot added a comment.Jan 13 2016, 11:19 PM

Change 263572 merged by jenkins-bot:
Submit updates via the job queue for PageAssessments

https://gerrit.wikimedia.org/r/263572

kaldari closed this task as Resolved.Jan 13 2016, 11:20 PM
• DannyH moved this task from Q3 2018-19 to Q1 2018-19 on the Community-Tech-Sprint board.Jan 14 2016, 5:56 PM
• DannyH edited projects, added Community-Tech; removed Community-Tech-Sprint.Jan 19 2016, 9:04 PM
• DannyH moved this task from Up Next (June 3-21) to Archive on the Community-Tech board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits