Page MenuHomePhabricator
Create Task
Maniphest T121096

Make "Smite Spam!" button appear only after results have loaded
Closed, ResolvedPublic
Actions

Description

Since T119298, two buttons appear in the Special:SmiteSpam interface even before the results have loaded, which doesn't make sense. These buttons should load only after the results have been loaded, and ideally this should happen even when a new page is being fetched.

Details

SubjectRepoBranchLines +/-
Make submit buttons appear only after results loadmediawiki/extensions/SmiteSpammaster+4 -1
Customize query in gerrit

Related Objects

Event Timeline

polybuildr created this task.Dec 10 2015, 12:36 PM
polybuildr raised the priority of this task from to Medium.
polybuildr updated the task description. (Show Details)
polybuildr added projects: MediaWiki-extensions-SmiteSpam, Google-Code-In-2015.
polybuildr moved this task to Backlog on the MediaWiki-extensions-SmiteSpam board.
polybuildr subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 10 2015, 12:36 PM
Aklapper added a comment.Dec 10 2015, 2:01 PM

https://codein.withgoogle.com/dashboard/tasks/5795756812271616/

Aklapper moved this task from Proposed to Imported into GCI site on the Google-Code-In-2015 board.Dec 10 2015, 2:01 PM
gerritbot subscribed.Dec 10 2015, 11:48 PM

Change 258382 had a related patch set uploaded (by MtDu):
Make submit buttons appear after results load

https://gerrit.wikimedia.org/r/258382

gerritbot added a project: Patch-For-Review.Dec 10 2015, 11:48 PM
gerritbot added a comment.Dec 12 2015, 8:08 PM

Change 258382 merged by jenkins-bot:
Make submit buttons appear only after results load

https://gerrit.wikimedia.org/r/258382

polybuildr closed this task as Resolved.Dec 12 2015, 8:08 PM
polybuildr assigned this task to MtDu.
polybuildr removed a project: Patch-For-Review.
polybuildr set Security to None.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL