| maiden_taiwan | |
| Dec 10 2015, 9:30 PM |
| F5218818: dpl-pagecounter-compat.diff | |
| Jan 2 2017, 10:02 PM |
The third-party DPL (DynamicPageList) extension breaks in MediaWiki 1.26 because the "page" table no longer contains a "page_counter" column. Example:
<dpl> category=whatever addpagecounter=true </dpl>
Error message produced:
Unknown column 'wp_page.page_counter' in 'field list' (localhost)
Ideally, DPL should detect whether Extension:HitCounters is installed and use that table, or it should exit cleanly with a message that "addpagecounter" is not supported.
This patch fixes the compability issues between the HitCounters extension and DPL. Maybe it doesn't fully honor the coding guidelines (I put all changes at one place), but it works ;-)
Tested on MediaWiki 1.27.1 with and without the HitCounters extension loaded.
Thank you for making the patch. Interestingly, I filed this bug report against a different extension that's also named DynamicPageList. I found the bug in the third-party extension known as DynamicPageList2, Your patch is against the original DynamicPageList from Wikimedia.
I guess the bug was present in both extensions, coincidentally.
Mass declining DynamicPageList (third-party) tickets per T353927: Archive the DynamicPageList (third-party) extension. If this is still relevant with the extension's successor, please feel free to refile at https://github.com/Universal-Omega/DynamicPageList3/issues.
For future reference (far too late to be useful here), if you have a patch that you would like to be seen and reviewed, please submit it to Gerrit rather than posting it as a Phabricator attachment.