Page MenuHomePhabricator

DPL "addpagecounter" breaks because page.page_counter column no longer exists
Open, Needs TriagePublic

Description

The third-party DPL (DynamicPageList) extension breaks in MediaWiki 1.26 because the "page" table no longer contains a "page_counter" column. Example:

<dpl>
category=whatever
addpagecounter=true
</dpl>

Error message produced:

Unknown column 'wp_page.page_counter' in 'field list' (localhost)

Ideally, DPL should detect whether Extension:HitCounters is installed and use that table, or it should exit cleanly with a message that "addpagecounter" is not supported.

Event Timeline

maiden_taiwan raised the priority of this task from to Needs Triage.
maiden_taiwan updated the task description. (Show Details)
maiden_taiwan added a subscriber: maiden_taiwan.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 10 2015, 9:30 PM
Brettz9 added a subscriber: Brettz9.Oct 3 2016, 4:52 AM
Cboltz added a subscriber: Cboltz.EditedJan 2 2017, 10:02 PM

This patch fixes the compability issues between the HitCounters extension and DPL. Maybe it doesn't fully honor the coding guidelines (I put all changes at one place), but it works ;-)

Tested on MediaWiki 1.27.1 with and without the HitCounters extension loaded.

Thank you for making the patch. Interestingly, I filed this bug report against a different extension that's also named DynamicPageList. I found the bug in the third-party extension known as DynamicPageList2, Your patch is against the original DynamicPageList from Wikimedia.

I guess the bug was present in both extensions, coincidentally.