Page MenuHomePhabricator

Add an option to show only IPs or accounts in get users
Open, MediumPublic

Description

Could an option please be added when using the 'get users' function to show actions/edits from IPs only and from accounts only (default behaviour should be to show both as it does now).

Thanks,
Callanecc

Event Timeline

Callanecc raised the priority of this task from to Needs Triage.
Callanecc updated the task description. (Show Details)
Callanecc added a project: CheckUser.
Callanecc subscribed.

So there would be some sort of magic JS form appearing when you select 'get users'?

Two ways to do this:

  • Include the option for IPs, accounts or both in the top form before making the request
  • Add filtering to the returned results that shows IPs, accounts or both.

The first would be server side, and would have the advantage that for busier ranges / smaller CIDRs the checks may run without timing out when a check for both times out. However, to look at the other data this would require another check.

The second would be done via JS, with a form like input that (with JS enabled) hides results completely on the client side. This would then allow quick switching back and forward. It would also mean this can be only shown when results are present, and would reduce the amount of screen space needed when no results are shown (i.e. before the check is run). This, however, is all client side so the benefit of when a check for both fails due to many results is reduced. If JS was used, then T279743 would need to be implemented first.

I think the JS option is (probably?) better here but I may ask for feedback on checkuser-l if I decide to work on this further.

Change 807217 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Add filters that allow only searching for users or IPs for get edits

https://gerrit.wikimedia.org/r/807217

Dreamy_Jazz triaged this task as Medium priority.

An interest was shown on the checkuser IRC. Written a patch and triaging this as medium.

Patch is now work in progress due to changes to how the pager is implemented in PHP.

Change 807217 abandoned by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] Add filters that allow only searching for users or IPs

Reason:

Same reason as the patch that depends on this + less need for this now that paging exists.

https://gerrit.wikimedia.org/r/807217

Unassigning as the patch needed improvement and this task is less important than others with patches open.