Page MenuHomePhabricator
Create Task
Maniphest T121281

[Bug] The login password alert icon overlaps the visibility icon
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Description

Steps to reproduce

  1. Go to the log in screen
  2. Enter a valid username and invalid password.
  3. Attempt to log in.

Expected results

The password alert icon appears adjacent the visibility icon.

Actual results

The password alert icon appears on top of the visibility icon.

screenshot-2015-12-11-15-29-17-765154034.png (2×1 px, 154 KB)

Environments observed

App version: 1bae506bdcc734b36ac60ecce7f7f008a6fcbbea
Android OS versions: API 23
Device model: Nexus 6P
Device language: English

Related Objects

Event Timeline

• Niedzielski created this task.Dec 11 2015, 10:33 PM
• Niedzielski raised the priority of this task from to Medium.
• Niedzielski updated the task description. (Show Details)
• Niedzielski added a project: Wikipedia-Android-App-Backlog.
• Niedzielski subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 11 2015, 10:33 PM
Dbrant added a project: Essential-Work.Dec 16 2015, 8:10 PM
Dbrant moved this task from Needs Triage to Bug Backlog on the Wikipedia-Android-App-Backlog board.
Dbrant subscribed.
Saylikarnik subscribed.Feb 14 2016, 1:36 PM

I'm interested in taking up this bug. How do I get started? I'm referring to the following link.
https://github.com/wikimedia/WikipediaMobile

• Mholloway subscribed.Feb 15 2016, 3:48 PM
• Niedzielski added a comment.Feb 15 2016, 4:12 PM

Michael is helping Saylikarnik get started via IRC.

Saylikarnik added a comment.Feb 20 2016, 5:13 PM

Submitted the patch for review.

Aklapper added a comment.Feb 29 2016, 10:47 AM
In T121281#2048022, @Saylikarnik wrote:

Submitted the patch for review.

@Saylikarnik: Please provide a link to the patch so someone could find it from here. Thanks!

MBinder_WMF set the point value for this task to 1.May 18 2016, 7:34 PM
MBinder_WMF added a project: Android-app-Bugs.Oct 6 2016, 11:20 PM
Venkatvb subscribed.Feb 21 2017, 8:48 PM
Dbrant claimed this task.Jun 13 2017, 5:16 PM
Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.19x-Cookie🍪); removed Wikipedia-Android-App-Backlog.
Restricted Application edited projects, added Wikipedia-Android-App-Backlog; removed Wikipedia-Android-App-Backlog (Android-app-release-v2.7.19x-Cookie🍪). · View Herald TranscriptJun 13 2017, 5:16 PM
Dbrant moved this task from Bug Backlog to Android-app-release-v2.7.19x-Cookie🍪 on the Wikipedia-Android-App-Backlog board.Jun 13 2017, 5:17 PM
Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.19x-Cookie🍪); removed Wikipedia-Android-App-Backlog.
Dbrant moved this task from To Do to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.19x-Cookie🍪) board.
Nicholas.tsg subscribed.Jun 21 2017, 1:13 PM

Testing on Samsung-SM-JI20A Galaxy Express 3 (Android 6.0.1) and Wikipedia app 2.6.198-alpha-2017-06-20. This is fixed as the screencap below shows the password alert no longer covers up the visibility icon.

T121281.png (800×480 px, 51 KB)

• Mholloway moved this task from QA Signoff to Ready for Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.19x-Cookie🍪) board.Jun 21 2017, 1:47 PM
Dbrant moved this task from Ready for Signoff to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.19x-Cookie🍪) board.Jun 30 2017, 2:00 PM
Dbrant closed this task as Resolved.Jun 30 2017, 2:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL