If I start clicking frantically on the "Allow" button, (sometimes just twice in a row, a common misclick) then the OAuth process usually fails. Sometimes it reports at 009 error (token already used), and sometimes it's a different error. This seems to be a pretty common issue among users of dashboard.wikiedu.org.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Disable authorization form button after submit | mediawiki/extensions/OAuth | master | +7 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T86869 Support a nice sso experience with MediaWiki's OAuth | |||
| Resolved | Ragesoss | T121287 Clicking 'Allow' multiple times quickly causes auth to fail | |||
| Resolved | Esanders | T102973 OOUI-ify the OAuth authorization dialog | |||
| Resolved | None | T113099 Create an OOUI dialog subclass for the OAuth authorization dialog |
Event Timeline
Comment Actions
Presumably the OOUI dialog prevents double-submit. Is this a big enough problem to fix in the current interface?
Also, do you know what the different error is? E009 is the expected behavior here (well, "expected" from a technical point of view), I'm curious what else could happen on a double-submit.
Comment Actions
Change 258724 had a related patch set uploaded (by Gergő Tisza):
Disable authorization form button after submit
Comment Actions
Thanks @Tgr! I don't remember exactly, and haven't been able to recreate, the other error(s) I've seen, but I'll keep closer watch.