Page MenuHomePhabricator

Some Echo messages probably don't need {{GENDER:$2}}
Open, Needs TriagePublic

Description

The message notification-bundle-header-edit-user-talk currently says:

$1 and $4 {{PLURAL:$5|other|others}} {{GENDER:$2|left}} a message on {{GENDER:$3|your}} talk page.

If I understand correctly, {{GENDER:$2|left}} refers to at least two people who left a message, and in this case the gender is probably irrelevant, because it is only useful for describing one person.

There are similar issues with notification-bundle-body-flow-post-reply and notification-bundle-header-flow-post-edited.

Event Timeline

Amire80 created this task.Dec 12 2015, 10:19 PM
Amire80 raised the priority of this task from to Needs Triage.
Amire80 updated the task description. (Show Details)
Amire80 added projects: I18n, Notifications.
Amire80 added a subscriber: Amire80.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript
Amire80 renamed this task from notification-bundle-header-edit-user-talk probably doesn't need {{GENDER:$2}} to Some Echo messages probably don't need {{GENDER:$2}}.Dec 12 2015, 10:44 PM
Amire80 updated the task description. (Show Details)
Amire80 set Security to None.

Yeah, the documentation should be clearer. $2 refers to the gender of $1.

Because of the way the infrastructure is set up, it's harder and more confusing to not pass in $2. So if we do anything, we could remove the gender hint on $2, but it would be more trouble than it's worth to actually remove the $2 parameter.

Amire80 moved this task from Untriaged to Gender on the I18n board.Feb 4 2018, 10:39 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 8 2018, 1:32 AM