Abstract more selection handling by selection type
Open, MediumPublic8 Estimated Story Points
Actions

Assigned To

None

Authored By

	Esanders
	Dec 13 2015, 4:22 PM

Description

Methods such as ve.ce.Surface#focus and handleInsertion should be less aware of selection types.

In general anywhere we write selection instanceof ve.(dm|ce).SomeTypeOfSelection.js, we should probably be rewriting that as selection.hasSomeProperty().

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Update VE core submodule to master (2ac0e8b0c)	mediawiki/extensions/VisualEditor	master	+1 -1
Use .isNull check for NullSelection	VisualEditor/VisualEditor	master	+7 -8
Move selection directionality to ve.ce.Selection	VisualEditor/VisualEditor	master	+53 -20
ve.ce.Selection: Introduce isFocusedNode && isNativeCursor methods	VisualEditor/VisualEditor	master	+58 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T78696 Break up ve.ce.Surface.js by functionality
		Open		None	T121347 Abstract more selection handling by selection type

Event Timeline

Esanders created this task.Dec 13 2015, 4:22 PM

Esanders raised the priority of this task from to Medium.

Esanders updated the task description. (Show Details)

Esanders added projects: Technical-Debt, VisualEditor-ContentEditable, VisualEditor.

Esanders added subscribers: gerritbot, Esanders, Aklapper.

Change 258756 had a related patch set uploaded (by Esanders):
ve.ce.Selection: Introduce isFocusedNode && isNativeCursor methods

https://gerrit.wikimedia.org/r/258756

gerritbot added a project: Patch-For-Review.Dec 13 2015, 4:34 PM

Change 258756 merged by jenkins-bot:
ve.ce.Selection: Introduce isFocusedNode && isNativeCursor methods

https://gerrit.wikimedia.org/r/258756

Jdforrester-WMF assigned this task to Esanders.Dec 15 2015, 8:12 PM

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Jdforrester-WMF removed a project: Patch-For-Review.

Jdforrester-WMF set Security to None.

Jdforrester-WMF edited a custom field.

Change 270776 had a related patch set uploaded (by Esanders):
Move selection directionality to ve.ce.Selection

https://gerrit.wikimedia.org/r/270776

gerritbot added a project: Patch-For-Review.Feb 15 2016, 5:30 PM

Change 270776 merged by jenkins-bot:
Move selection directionality to ve.ce.Selection

https://gerrit.wikimedia.org/r/270776

Still stuff to do, according to Ed.

Jdforrester-WMF removed Esanders as the assignee of this task.Mar 25 2017, 3:22 AM

• Deskana moved this task from TR0: Interrupt to Freezer on the VisualEditor board.Oct 13 2017, 11:55 AM

Change 408316 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Use .isNull check for NullSelection

https://gerrit.wikimedia.org/r/408316

gerritbot added a project: Patch-For-Review.Feb 5 2018, 5:53 PM

Esanders updated the task description. (Show Details)Feb 6 2018, 2:04 PM

Change 408316 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Use .isNull check for NullSelection

https://gerrit.wikimedia.org/r/408316

Change 408721 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2ac0e8b0c)

https://gerrit.wikimedia.org/r/408721

With that merged, there are still 30 instanceof calls in ve.ce.Surface.js. How many is "done"?

Change 408721 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2ac0e8b0c)