In order to run MediaWiki in the authoritative repo mode I need to tell HHVM about all PHP files that might possibly get required or included.
Currently I am just adding *.lesscache all files that happen to be in my $wgCacheDirectory but it would be better to have something more robust for automated production deployment.
Something like a maintenance script to do that would be great.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| resourceloader: Disable filesystem cache for Less | mediawiki/core | master | +0 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T121913 Enable HHVM Repo Authoritative mode | |||
| Resolved | Krinkle | T121519 Don't use PHP files on-disk for lesscache |
For a scalable and performant production environment one shouldn't use file caching for LESS to begin with.
It seems we currently do have them in production (e.g. mw1018:/tmp/mw-cache-1.27.0-wmf.9/lessphp_*.lesscache).
The new parsing library we use for Less has a better way to cache the intermediate representation. It defaults to .php files that are evaluated from disk, but it also supports a callback that is given serialised PHP data. We should consider using that instead.
In addition to this, we also have our own LESS caching layer. So it might even make sense to disable the internal one entirely.
Relevant code:
Options:
The outcome will depend on how good Less_Parser is at re-using cache and evaluating whether the cache is stale or not.
It seems these files show relatively high in XHGui's Memory Hog detection.
Here's a request for modules=mmv instrumented, https://performance.wikimedia.org/xhgui/run/view?id=56c9d64f7ed6cca41b13ad3e
Top 5 memory hogs:
| run_init::/tmp/mw-cache-1.27.0-wmf.13/lessphp_qmxbqxz5374sko4ockwsck8ksowwk4k.lesscache | 12,744,904 bytes |
| run_init::/tmp/mw-cache-1.27.0-wmf.13/lessphp_a6c7hcdc0tckc4kswgs008gogoosgkk.lesscache | 12,682,000 bytes |
| Less_Parser::ArgString@1 | 1,793,856 bytes |
| run_init::/tmp/mw-cache-1.27.0-wmf.13/lessphp_qf2nq1iptf4o4co8ggcww04owk0oos8.lesscache | 831,224 bytes |
| APCBagOStuff::set | 595,576 bytes |
| JavaScriptMinifier::minify | 460,921 bytes |
Change 303078 had a related patch set uploaded (by Krinkle):
resourceloader: Disable filesystem cache for Less
Change 303078 merged by jenkins-bot:
resourceloader: Disable filesystem cache for Less