Page MenuHomePhabricator
Create Task
Maniphest T121563

Should be possible for banners to come from PageImages extension
Closed, ResolvedPublic
Actions

Description

It is desirable to use the PageImages extension as an alternative source for images that power the banners.
Expected source of image:

  1. If user specified a file name use that (even if red link)
  2. If user didn't specify a file name and Wikidata banner property is set fall back to Wikidata banner
  3. If user didn't specify a file name, and no wikidata banner/no wikidata banner property and PageImages set use PageImages
  • PageImage support is configurable
  • Image can come from PageImages when enabled
  • It should be configurable to swap the order so that PageImages are preferred to Wikidata banners.
  • PageImages support enabled on wikipedias

Details

SubjectRepoBranchLines +/-
Banners can come from PageImages extension when installedmediawiki/extensions/WikidataPageBannermaster+81 -22
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Dec 15 2015, 7:12 PM
Jdlrobson raised the priority of this task from to Medium.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Wikidata-Page-Banner, PageImages.
Jdlrobson moved this task to In discussion on the Wikidata-Page-Banner board.
Jdlrobson subscribed.
Restricted Application added a project: Wikidata. · View Herald TranscriptDec 15 2015, 7:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson renamed this task from Should we possible for banners to come from PageImages extension to Should be possible for banners to come from PageImages extension.Dec 15 2015, 7:12 PM
Jdlrobson set Security to None.
gerritbot subscribed.Dec 15 2015, 7:12 PM

Change 239010 had a related patch set uploaded (by Jdlrobson):
Banners can come from PageImages extension when installed

https://gerrit.wikimedia.org/r/239010

gerritbot added a project: Patch-For-Review.Dec 15 2015, 7:12 PM
Jdlrobson updated the task description. (Show Details)Dec 15 2015, 7:14 PM
Jdlrobson added a project: Reading-Web-Sprint-63-Ellip….Dec 15 2015, 7:56 PM
Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Dec 17 2015, 11:47 AM
Jdlrobson moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-63-Ellip… board.Dec 22 2015, 12:44 AM
Jdlrobson claimed this task.Dec 22 2015, 12:51 AM
• bmansurov added subscribers: phuedx, • bmansurov.EditedDec 28 2015, 11:26 AM

The patch looks good. @phuedx, would you be kind enough to review it too? I don't feel like merging something I'm not very familiar with well.

phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-63-Ellip… board.Dec 29 2015, 12:46 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-63-Ellip… board.Dec 29 2015, 5:19 PM
gerritbot added a comment.Jan 19 2016, 7:40 PM

Change 239010 merged by jenkins-bot:
Banners can come from PageImages extension when installed

https://gerrit.wikimedia.org/r/239010

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)).Jan 19 2016, 8:00 PM
Jdlrobson closed this task as Resolved.Jan 19 2016, 8:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL