// set cookie and save settings only when this is not a
// networkauth user
if (! in_array($username, $this->networkauthusers)) {
$user->saveSettings();
$user->setCookies();
}
Hooks::run('UserLoginComplete', array(&$user, ""));
}Passing a blank string is unrighteous because a reference should be passed in case the Hook returns or modifies the value. https://www.mediawiki.org/wiki/Manual:Hooks/UserLoginComplete
should instead be:
// set cookie and save settings only when this is not a
// networkauth user
if (! in_array($username, $this->networkauthusers)) {
$user->saveSettings();
$user->setCookies();
}
$inject_html = '';
Hooks::run('UserLoginComplete', array(&$user, &$injected_html));
}I have managed to produce some errors with this (setup to tricky too explain at the moment and with <sigh> other problems but I think this is reasonably evident - a screenshot
