Page MenuHomePhabricator
Create Task
Maniphest T121599

On Single Edit tab wikis, Section edit link shows both "Edit" and "Edit Source" option , after saving an edit using VisualEditor while having preference "Remember my last editor" and "Always VE"
Closed, ResolvedPublic1 Story Points
Actions

Description

Steps to reproduce:

  1. Set the preference as "Always give me the VisualEditor if possible"
  2. Have the section editing link enabled
  3. Now click on Edit button
  4. Edit something using VE

5.Save the edit

Observe that , earlier in the section editing link there was just option "Edit", now after saving the edit using VE, "Edit Source" also appearing next to it

This happens when you have preference, "Remember my last editor" enabled and save an edit using VE (where Ve was your last used editor"

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterSET: Don't try to do any client-side section link magic if we're not supposed to.

Related Objects
Search...

StatusAssignedTask
 OpenNoneT52000 Enable VisualEditor by default for all users of all Wikimedia wikis
 OpenNoneT51999 Enable VisualEditor by default for all users of all Wikipedias
 OpenNoneT90662 Re-enable VisualEditor by default for all users of the English Wikipedia
 OpenNoneT90663 Re-enable VisualEditor by default for all logged-out users of the English Wikipedia
 ResolvedJules78120T117281 Create a MOOC about French Wikipedia
 OpenNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 ResolvedKrenairT55441 VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor)
 Resolved• AlexMonk-WMFT55746 VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one
 OpenNoneT114531 VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation
 ResolvedKrenairT89060 VisualEditor is not the editor linked from the diff page
 OpenNoneT78550 The undo link in the page history leads to the source editor and not VisualEditor
 OpenNoneT185548 Undo notification is not sent if the editor switches to the visual editor
 OpenNoneT54162 VisualEditor: If VisualEditor is the primary editor, type=create and type=fulltext buttons should point to VE, not WT editor
 OpenNoneT102398 Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them
 ResolvedKrenairT54281 VisualEditor: VE should use the existing "action" URL parameter instead of the new "veaction"
 ResolvedKrenairT58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
 ResolvedKrenairT121599 On Single Edit tab wikis, Section edit link shows both "Edit" and "Edit Source" option , after saving an edit using VisualEditor while having preference "Remember my last editor" and "Always VE"

Event Timeline

Ryasmeen created this task.Dec 15 2015, 11:48 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen added a subscriber: Ryasmeen.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 15 2015, 11:48 PM
Ryasmeen set Security to None.Dec 17 2015, 1:01 AM
Ryasmeen added a subscriber: Krenair.
Krenair added a comment.Dec 17 2015, 2:19 AM

Interesting. After saving, we just call action=parse and return the result to the client to replace the page with.

Krenair added a comment.EditedDec 17 2015, 2:30 AM

Ah, and then try to do some magic that we usually shouldn't be doing in SET. Okay.

gerritbot added a subscriber: gerritbot.Dec 17 2015, 2:35 AM

Change 259631 had a related patch set uploaded (by Alex Monk):
SET: Don't try to do any client-side section link magic if we're not supposed to.

https://gerrit.wikimedia.org/r/259631

gerritbot added a comment.Dec 23 2015, 11:18 PM

Change 259631 merged by jenkins-bot:
SET: Don't try to do any client-side section link magic if we're not supposed to.

https://gerrit.wikimedia.org/r/259631

Krenair closed this task as Resolved.Dec 23 2015, 11:20 PM
Jdforrester-WMF triaged this task as High priority.Jan 3 2016, 7:44 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL