On Single Edit tab wikis, Section edit link shows both "Edit" and "Edit Source" option , after saving an edit using VisualEditor while having preference "Remember my last editor" and "Always VE"
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Ryasmeen
	Dec 15 2015, 11:48 PM

Description

Steps to reproduce:

Set the preference as "Always give me the VisualEditor if possible"
Have the section editing link enabled
Now click on Edit button
Edit something using VE

5.Save the edit

Observe that , earlier in the section editing link there was just option "Edit", now after saving the edit using VE, "Edit Source" also appearing next to it

This happens when you have preference, "Remember my last editor" enabled and save an edit using VE (where Ve was your last used editor"

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	SET: Don't try to do any client-side section link magic if we're not supposed to.	mediawiki/extensions/VisualEditor	master	+11 -1

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	Krenair	T58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
Resolved	Krenair	T121599 On Single Edit tab wikis, Section edit link shows both "Edit" and "Edit Source" option , after saving an edit using VisualEditor while having preference "Remember my last editor" and "Always VE"
		· · ·

Event Timeline

Ryasmeen created this task.Dec 15 2015, 11:48 PM

Ryasmeen raised the priority of this task from to Needs Triage.

Ryasmeen updated the task description. (Show Details)

Ryasmeen added a project: VisualEditor.

Ryasmeen subscribed.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 15 2015, 11:48 PM

Ryasmeen set Security to None.Dec 17 2015, 1:01 AM

Ryasmeen added a subscriber: Krenair.

Interesting. After saving, we just call action=parse and return the result to the client to replace the page with.

Ah, and then try to do some magic that we usually shouldn't be doing in SET. Okay.

Change 259631 had a related patch set uploaded (by Alex Monk):
SET: Don't try to do any client-side section link magic if we're not supposed to.

https://gerrit.wikimedia.org/r/259631

gerritbot added a project: Patch-For-Review.Dec 17 2015, 2:35 AM

Krenair claimed this task.Dec 17 2015, 2:37 AM

Krenair added a parent task: T58337: Change VE integration to only use one edit tab, to avoid user choice paralysis.

Change 259631 merged by jenkins-bot:
SET: Don't try to do any client-side section link magic if we're not supposed to.

https://gerrit.wikimedia.org/r/259631

Krenair closed this task as Resolved.Dec 23 2015, 11:20 PM

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Dec 24 2015, 12:00 AM

Jdforrester-WMF triaged this task as High priority.Jan 3 2016, 7:44 PM

Jdforrester-WMF removed a project: Patch-For-Review.

Jdforrester-WMF edited a custom field.

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Jan 13 2016, 4:32 PM

On Single Edit tab wikis, Section edit link shows both "Edit" and "Edit Source" option , after saving an edit using VisualEditor while having preference "Remember my last editor" and "Always VE"Closed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related ObjectsSearch...

Event Timeline

On Single Edit tab wikis, Section edit link shows both "Edit" and "Edit Source" option , after saving an edit using VisualEditor while having preference "Remember my last editor" and "Always VE"
Closed, ResolvedPublic1 Estimated Story Points
Actions

Related Objects
Search...