Page MenuHomePhabricator

[Epic] Saved pages legacy functionality
Closed, ResolvedPublic

Description

Restore legacy functionality for saved pages:

  • As a user, I can delete all my saved pages at once
  • As a user, I can refresh all my saved pages
    • As a user, I should see a progress bar that indicates how many articles are remaining to be saved

See blocking tasks for more information

Event Timeline

As a user, I can delete all my saved pages at once

  • As a user, I can refresh all my saved pages

    Saved pages can have default iOS UIRefreshControl (pull down to refresh) it's a common pattern and doesn't suffer from discoverability.

    As a user, I should see a progress bar that indicates how many articles are remaining to be saved

    The progress can be indicated using the placeholder card xib. the same pattern we use while loading cards on our feed.

    @Nirzar not seeing refresh mocks in that pholio. Some comments below:

    Saved pages can have default iOS UIRefreshControl (pull down to refresh) it's a common pattern and doesn't suffer from discoverability.

    That's possible, but do you not want to show overall progress (e.g. downloading 1/8 pages, 2/8, etc.)?

    The progress can be indicated using the placeholder card xib. the same pattern we use while loading cards on our feed.

    Are you sure? Using feed placeholders here doesn't make sense because the placeholders are meant to show something where we have nothing. Here, we have article title, extract, & lead image (at most). Instead, would it be better to somehow indicate it's being loaded while still showing all the information we have?

    I suppose we could use UIRefreshControl.attributedTitle to show overall progress (e.g. "Refreshing X of Y")

    MBinder_WMF raised the priority of this task from Medium to High.Feb 16 2016, 10:20 PM
    JMinor lowered the priority of this task from High to Medium.Feb 16 2016, 11:09 PM

    Yes. We never implemented progress bars, but probably won't until we do full Reading Lists support. We always have the tag now anyway....

    JMinor claimed this task.