Page MenuHomePhabricator

Pressing Escape in the GUI editor shouldn't lose all my work
Closed, DuplicatePublic

Description

Steps to lose your work:

  1. Open the TemplateData editor. Be very happy about the new "suggested" parameters feature.
  1. Add a bunch of stuff.
  1. Try to add another parameter, but realize that the reason the "Add parameter" button is grayed out. Maybe it was in the list of suggested parameters that I imported?
  1. Press 'Escape' to get out of this box and back to the main one.
  1. Groan as you realize that 'Escape' canceled the entire TemplateData editing session, not just the effort to add the one (duplicate) parameter and does not produce an "are you sure you want to lose all your work?" warning.

Event Timeline

Whatamidoing-WMF raised the priority of this task from to Needs Triage.
Whatamidoing-WMF updated the task description. (Show Details)
Whatamidoing-WMF added a project: TemplateData.
Whatamidoing-WMF added a subscriber: Whatamidoing-WMF.

Change 263547 had a related patch set uploaded (by Alex Monk):
Send escape key cancel events through action handler as undefined

https://gerrit.wikimedia.org/r/263547

Change 263556 had a related patch set uploaded (by Alex Monk):
Prompt user to confirm closing TemplateData edit dialog

https://gerrit.wikimedia.org/r/263556

Jdforrester-WMF set Security to None.

Change 263547 merged by jenkins-bot:
Send escape key cancel events through action handler

https://gerrit.wikimedia.org/r/263547