| Catrope | |
| Dec 17 2015, 12:45 AM |
| F3328777: Screen Shot 2016-02-09 at 3.32.37 PM.png | |
| Feb 9 2016, 11:36 PM |
| F3177516: flow-topic-renamed.svg | |
| Dec 29 2015, 1:06 PM |
| F3177504: flow-post-edited.svg | |
| Dec 29 2015, 1:06 PM |
| F3177478: pagetriage-mark-as-reviewed.svg | |
| Dec 29 2015, 12:57 PM |
| F3177438: flow-new-topic.svg | |
| Dec 29 2015, 12:57 PM |
| F3177413: emailuser.svg | |
| Dec 29 2015, 12:57 PM |
| F3177385: user-rights.svg | |
| Dec 29 2015, 12:57 PM |
| F3177457: flow-post-reply.svg | |
| Dec 29 2015, 12:57 PM |
Pau has new icon designs for:
There are also new icons for reverted and page-linked, but those are already covered in T121624: Clarify link and revert icons on notifications
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | MtDu | T121735 Clarify notification icons | |||
| Resolved | MtDu | T121624 Clarify link and revert icons on notifications | |||
| Resolved | MtDu | T125785 Use updated trash icon on deletion-related notifications |
Change 259785 had a related patch set uploaded (by MtDu):
Clarify link and revert icons on notifications
I added the icons (and extended the list with "flow-post-edited" and "flow-topic-renamed").
Moving it to ready to pick up, unless anything else is missing.
Change 263808 had a related patch set uploaded (by MtDu):
Clarify some notification icons - edit-user-talk - mention - user-rights - emailuser
It seems as if not all the icons are in the echo extension. Will have to edit Flow and Gather and one more for pagetriage (Don't know which, please help)? For Flow, this is the notifications.php file. https://dpaste.de/Cewq#L8,39,63,84,97 They have a default icon. What is the best way to implement the new svg files since they no longer use the default one? Also, what is the extension that needs modification for the new pagetriage icon?
Thanks,
MtDu
Assuming every single Flow notification will now have a different icon (is that true? I didn't check), it's probably best to remove the default icon and specify the icon for each individual type, like Echo already does. Also, as I pointed out on https://gerrit.wikimedia.org/r/#/c/263808/1/Echo.php , you'll have to change the presentation model classes as well. Flow also uses a default icon type there (in the FlowPresentationModel base class), so you'd have to move that up to the specific presentation models for each notification type as well.
If it does still make sense to have a default icon (i.e. if multiple notification types use the same icon, and that icon is generic) then you can simply leave it in place, and specify it in places where it needs to be different. Specifying an icon for a specific type automatically overrides the default.
Change 264212 had a related patch set uploaded (by MtDu):
Clarify some notification icons *flow-new-topic *flow-post-edited *flow-post-reply *flow-topic-renamed
One question. For the page triage icon, the default one currently is 'checkmark', but when I look through the files, I can't find a path to icon 'checkmark'. Could someone tell me which icon that is so I can replace it with the correct one and put it in the right place?
Thanks,
MtDu
I think the pagetriage icon should replace reviewed in Echo. Correct me if I'm wrong.
Update:
Reviewed uses the same icon as checkmark. Will keep review icon and use the new pagetriage icon for checkmark.
Change 264216 had a related patch set uploaded (by Catrope):
Update Flow notification icons
I think you should probably do the reverse: given what the new pagetriage icon looks like, I think 'reviewed' is a better name than 'checkmark'. In any case, it's silly that we currently have two names for the same icon, one of which is unused. I tried to clean up a bit of that in https://gerrit.wikimedia.org/r/#/c/264140
Change 264230 had a related patch set uploaded (by MtDu):
Replace Talk icon with new flow-post-reply icon
Change 264243 had a related patch set uploaded (by MtDu):
Use new pagetriage-mark-as-reviewed icon
Checked in betalabs as part of {T123934: Rephrase Echo 'edit-user-talk' notifications} and {T121737: Add secondary link for the agent to some notification types}
reverted - {T121808: Add excerpt of edit summary to reverted notification}
Linked pages
