Page MenuHomePhabricator

Quotes needed for timestamps in PostgreSQL
Closed, ResolvedPublic

Description

The fix for bug T114806 doesn't quote timestamps it sends directly to the database (i.e. not in bind variables).

For reasons I don't understand, this causes 'php phpunit.php includes/ImportLinkCacheIntegrationTest.php' to blow up spectacularly when used against PostgreSQL, consuming all memory and crashing.

A simple addQuotes fixes that problem, but it would be nice to fix the problem with phpunit that causes infinite loops with memory allocation, too.

Event Timeline

Jjanes created this task.Dec 17 2015, 5:16 AM
Jjanes updated the task description. (Show Details)
Jjanes raised the priority of this task from to Needs Triage.
Jjanes added a project: MediaWiki-Database.
Jjanes added a subscriber: Jjanes.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 17 2015, 5:16 AM

Change 259636 had a related patch set uploaded (by Jjanes):
PostgreSQL: Add quotes to timestamp

https://gerrit.wikimedia.org/r/259636

Change 259636 merged by jenkins-bot:
PostgreSQL: Add quotes to timestamp

https://gerrit.wikimedia.org/r/259636

Paladox closed this task as Resolved.Jan 6 2017, 11:37 PM
Paladox assigned this task to Jjanes.