Page MenuHomePhabricator

[Task] Pass known visibility state from statementview to toggler
Closed, ResolvedPublic

Description

On an item with 100 statements, 100 reference sections are created. Each is either toggled if it contains at least one reference, or not toggled if it is empty. This is decided in statementview, but not passed to the toggler. The toggler must to an expensive visibility check on the reference section. This can easily be avoided.

On my local machine (with all caching disabled, and therefor way slower than in production) this saves about 300ms on an item with 100 statements.

Patches for review:

Event Timeline

thiemowmde claimed this task.
thiemowmde raised the priority of this task from to Medium.
thiemowmde updated the task description. (Show Details)
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 17 2015, 5:45 PM
hoo closed this task as Resolved.Jan 16 2016, 1:29 AM
hoo removed a project: Patch-For-Review.
hoo set Security to None.
hoo moved this task from Review to Done on the Wikidata-Sprint-2015-12-01 board.