Page MenuHomePhabricator
Create Task
Maniphest T121832

Completion suggester beta feature is missing an RTL logo
Closed, ResolvedPublic
Actions

Description

See screenshot below from the Beta Features page on the Hebrew Wikipedia. The logo at the top, for the completion suggester, should be flipped in an RTL context so it makes sense to the user. An example of a properly flipped logo is at the bottom of the screenshot.

Screen Shot 2015-12-17 at 17.25.10.png (1×1 px, 131 KB)

Details

SubjectRepoBranchLines +/-
Point completion suggester beta feature rtl icon at the rtl iconmediawiki/extensions/CirrusSearchmaster+1 -1
Customize query in gerrit

Event Timeline

• Deskana created this task.Dec 18 2015, 1:26 AM
• Deskana raised the priority of this task from to Medium.
• Deskana updated the task description. (Show Details)
• Deskana added projects: Discovery-ARCHIVED, Discovery-Search (Current work).
• Deskana subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 18 2015, 1:26 AM
• Deskana moved this task from Needs triage to On Sprint Board on the Discovery-ARCHIVED board.Dec 18 2015, 1:27 AM
Quiddity subscribed.Dec 18 2015, 1:27 AM
gerritbot subscribed.Dec 18 2015, 1:27 AM

Change 259963 had a related patch set uploaded (by Deskana):
Point completion suggester beta feature rtl icon at the rtl icon

https://gerrit.wikimedia.org/r/259963

gerritbot added a project: Patch-For-Review.Dec 18 2015, 1:27 AM
gerritbot added a comment.Dec 18 2015, 11:20 AM

Change 259963 merged by jenkins-bot:
Point completion suggester beta feature rtl icon at the rtl icon

https://gerrit.wikimedia.org/r/259963

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Dec 18 2015, 12:00 PM
EBernhardson claimed this task.Dec 18 2015, 8:22 PM
EBernhardson moved this task from Incoming to Needs Reporting on the Discovery-Search (Current work) board.
EBernhardson set Security to None.
Amire80 awarded a token.Dec 19 2015, 6:48 PM
Amire80 added a project: RTL.
Restricted Application added a project: I18n. · View Herald TranscriptDec 19 2015, 6:49 PM
• Deskana added a comment.Dec 19 2015, 7:08 PM

The above patch fixes the issue, but given the holiday deployment schedule this fix won't be pushed out until the new year.

• Deskana closed this task as Resolved.Jan 23 2016, 4:01 AM

Verified fixed: https://he.wikipedia.org/wiki/%D7%9E%D7%99%D7%95%D7%97%D7%93:%D7%94%D7%A2%D7%93%D7%A4%D7%95%D7%AA#mw-prefsection-betafeatures

• Deskana moved this task from Needs Reporting to Resolved on the Discovery-Search (Current work) board.Jan 28 2016, 6:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL