Page MenuHomePhabricator

[5.0.0.563] Offline mode - cached Explore page issues
Closed, ResolvedPublic

Description

Found while testing T117925: As a user without internet connection I want a smooth user experience
This is a case when users are switching to Flight mode (or losing their internet connection) when they are not on the Explore page.

  1. Open the app and perform a search or/and go to one of the Saved or Recent articles - stay on the article.
  2. Switch to offline mode.
  3. Return to the app - the viewed article is still displayed. You can navigate to the Explore page(cached). It does not refresh even upon displaying to a user the warning banner.

Instead of refreshing, the Explore page show gradual signs of unsuccessful attempts to refresh

  • some suggested articles stop showing their lead imgs
  • Random article - when click on Reload, starts reloading indefinitely
  • Nearby section shows 'Nothing nearby' (three times)

IMG_0485.PNG (2×1 px, 96 KB)

Event Timeline

Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova subscribed.

I moved this back after testing using the steps Elena describes. I opened a saved article, activated Airplane mode, and then went back to Explore. I scrolled down past cached items and saw empty headers. I tapped a Featured Article header and the app crashed.

@JMinor - we just expecting the no connection view to be displayed - correct?

Yes. And it works in most cases, but if you lose connection while article is displayed you get funkiness instead.

Fixed - checked with 5.0.0 (736) on iPad mini iOS 8.2 and iPhone 6 iOS 9.0 - when there is no Internet connection, navigation to Explore page or opening the app on the Explore page smoothly transitions to a page with a message "No Internet Connection"

There is the issue filed as T128142: [5.0.0 (736)] Restoring Internet connection causes Explore page to jitter & display No results - switching back from Airplane mode does not look so smooth.