Page MenuHomePhabricator

Use mustache templates in SF helper forms, instead of a hidden div that is cloned with JS
Open, Needs TriagePublic

Description

https://www.mediawiki.org/wiki/Manual:HTML_templates

Native starting from 1.25, so perhaps a little bit too early to use for SF, since I seem to remember they like their backwards compatibility.
However. much better than cloned hidden divs as used by:
https://github.com/wikimedia/mediawiki-extensions-SemanticForms/blob/5c90c4767e3924b53cf2eae50faddd8a01da88d2/specials/SF_CreateTemplate.php#L96

The mobile team did have templates earlier, possibly that could be used for older MW versions through stubs.

Event Timeline

TheDJ created this task.Dec 19 2015, 10:15 AM
TheDJ assigned this task to Yaron_Koren.
TheDJ raised the priority of this task from to Needs Triage.
TheDJ updated the task description. (Show Details)
TheDJ added a subscriber: TheDJ.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 19 2015, 10:15 AM
Yaron_Koren renamed this task from Use templates, to avoid inserting a hidden div that is cloned with JS to Use mustache templates in SF helper forms, instead of a hidden div that is cloned with JS.Dec 20 2015, 2:08 PM
Yaron_Koren set Security to None.

Renamed, for clarity.

Yaron_Koren removed Yaron_Koren as the assignee of this task.Mar 18 2020, 6:23 PM
Yaron_Koren added a subscriber: Yaron_Koren.