Page MenuHomePhabricator

Citation breaks when enter data format in MM/DD/YYYY; US BLS site fails to auto-create
Closed, ResolvedPublic1 Estimated Story Points

Description

Hi James,

You can see the diff of me correcting the citation here:
https://en.wikipedia.org/w/index.php?title=Civil_engineer&diff=695920805&oldid=695920693

Steps I took:
Use VE citation tool to insert citation
Paste http://www.bls.gov/ooh/architecture-and-engineering/civil-engineers.htm (US Bureau of Labor Statistics) into URL, this will fail for automatic creation
Use manual citation screen
Put access date as MM/DD/YYYY
See broken citation below

We should probably be checking for format as the user types in real time

Event Timeline

LilaTretikov assigned this task to Jdforrester-WMF.
LilaTretikov raised the priority of this task from to Needs Triage.
LilaTretikov updated the task description. (Show Details)
LilaTretikov added a project: VisualEditor.
LilaTretikov subscribed.

That date format isn't "invalid" in the strict sense. Instead, that date format is rejected by the local template. That's why there was a red error message in the context menu, when the parsed template was displayed:

Screen Shot 2015-12-23 at 6.29.01 PM.png (388×1 px, 83 KB)

The only reason it generates an error message is because the local community wrote the template to actively discourage the use of that date format. Only some wikis have a local rule against using that date format, and only some wikis have templates that use error messages in some citations templates to discourage its use. (And more wikis don't have the rule, but do have some templates copied from a wiki that does have that rule, so they get the error message even though the format is not an error on their wiki.)

I'm not convinced that it makes sense to make the software enforce stylistic rules that only exist at a fraction of wikis.

Jdforrester-WMF edited a custom field.

Yeah, I agree that we shouldn't enforce date styling conventions in code, but we should certainly try to get that site working in Citoid. :-)

Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Works now: I suspect this was caused by T98782.