Page MenuHomePhabricator
Create Task
Maniphest T121987

Flow VE: Link inspector displays 'Edit' and 'delete'(oo-ui-buttonElement-framed) in different sizes
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To
Catrope
Authored By
Etonkovidova
Dec 19 2015, 7:46 PM
Tags
Referenced Files
F3125461: Screen Shot 2015-12-19 at 11.06.16 AM.png
Dec 19 2015, 7:46 PM
F3125478: Screen Shot 2015-12-19 at 11.44.34 AM.png
Dec 19 2015, 7:46 PM
F3125471: Screen Shot 2015-12-19 at 11.07.07 AM.png
Dec 19 2015, 7:46 PM
F3125442: Screen Shot 2015-12-19 at 11.07.58 AM.png
Dec 19 2015, 7:46 PM
Subscribers
Aklapper
Etonkovidova
gerritbot
• Mattflaschen-WMF
StudiesWorld

Description

  1. Click to Reply - make sure that you're in VE mode
  2. Create a link or click on an existing link
  3. The link inspector displays 'Edit'(oo-ui-flaggedElement-progressive) and 'delete'(oo-ui-flaggedElement-destructive)

Screen Shot 2015-12-19 at 11.06.16 AM.png (314×607 px, 40 KB)

Screen Shot 2015-12-19 at 11.44.34 AM.png (251×1 px, 31 KB)

On on non-flow pages, two boxes are of the same size.

Screen Shot 2015-12-19 at 11.07.58 AM.png (248×587 px, 22 KB)

Screen Shot 2015-12-19 at 11.07.07 AM.png (235×758 px, 39 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix sizes of VE buttons in Flowmediawiki/extensions/Flowmaster+4 -0
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Dec 19 2015, 7:46 PM
Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added projects: StructuredDiscussions, Collaboration-Team-Triage.
Etonkovidova subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 19 2015, 7:46 PM
• Mattflaschen-WMF added a project: VisualEditor.Dec 21 2015, 11:17 PM
• Mattflaschen-WMF subscribed.
Jdforrester-WMF renamed this task from Talk page VE: Link inspector displays 'Edit' and 'delete'(oo-ui-buttonElement-framed) in different sizes to Flow VE: Link inspector displays 'Edit' and 'delete'(oo-ui-buttonElement-framed) in different sizes .Jan 12 2016, 8:23 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
gerritbot subscribed.Jan 12 2016, 9:58 PM

Change 263742 had a related patch set uploaded (by Catrope):
Fix sizes of VE buttons in Flow

https://gerrit.wikimedia.org/r/263742

gerritbot added a project: Patch-For-Review.Jan 12 2016, 9:58 PM
gerritbot added a comment.Jan 12 2016, 10:38 PM

Change 263742 merged by jenkins-bot:
Fix sizes of VE buttons in Flow

https://gerrit.wikimedia.org/r/263742

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)).Jan 12 2016, 11:00 PM
Catrope claimed this task.Jan 13 2016, 8:23 AM
Catrope edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.
Catrope moved this task from Untriaged to QA Review on the Collaboration-Team-Archive-2015-2016 board.
Etonkovidova added a comment.Jan 14 2016, 6:45 PM

Checked in betalabs - VE 'Clear styling' and 'Edit' boxes are even now.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Jan 14 2016, 6:46 PM
Catrope closed this task as Resolved.Jan 19 2016, 1:05 AM
Jdforrester-WMF moved this task from Freezer to TR0: Interrupt on the VisualEditor board.Jan 19 2016, 1:05 AM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits