Page MenuHomePhabricator

Unconfirmed: Related articles Beta throws JS errors in production
Closed, ResolvedPublic

Description

Exception with thrown value: TypeError: CSS.escape is not a function. (In 'CSS.escape(attributes.thumbnailUrl)', 'CSS.escape' is undefined)

from inside the render call called by the block:

function CardView(model) {
    this.model = model;
    this.model.on('change', this.render.bind(this));
    this.$el = $(this._render());

Event Timeline

TheDJ raised the priority of this task from to Unbreak Now!.
TheDJ updated the task description. (Show Details)
TheDJ added a project: RelatedArticles.
TheDJ added a subscriber: TheDJ.
Jdlrobson lowered the priority of this task from Unbreak Now! to High.Dec 22 2015, 12:47 AM
Jdlrobson added a subscriber: Jdlrobson.

Where are you seeing this @TheDJ as I can't replicate.

Obvious questions - what page, what browser, desktop or mobile...?

Jdlrobson renamed this task from Related articles Beta throws JS errors in production to Uncomfirmed: Related articles Beta throws JS errors in production.Dec 22 2015, 12:47 AM
Jdlrobson set Security to None.

I have this on many english wikipedia pages:
For instance, just now on: https://en.wikipedia.org/wiki/Sylvester,_Georgia#External_links

Logged in, Safari.

I guess ext.cards.lib is executed after ext.cards. The DOM is already ready, causing the DOM ready of ext.cards to be executed immediately, while the ext.cards.lib has not finished executing (or exporting vars ?) yet. Are the dependencies correctly defined ?

I also notice that ext.cards is not 'importing' the CSS object, but instead directly using it from the global context.

Weird I still can't replicate.. even on Safari. Are you sure a gadget is not interfering?

Jdlrobson lowered the priority of this task from High to Medium.Jan 11 2016, 6:50 PM
Aklapper renamed this task from Uncomfirmed: Related articles Beta throws JS errors in production to Unconfirmed: Related articles Beta throws JS errors in production.Feb 2 2016, 12:26 PM
Jdlrobson changed the task status from Open to Stalled.Feb 5 2016, 12:32 AM

While this is in beta let's stall on the upstream bug.

@MBinder_WMF, @Jdlrobson - from our discussion today, I was under the impression this is still stalled

Jdlrobson claimed this task.

The upstream bug has been fixed. I don't think there is any more we can do here.