Page MenuHomePhabricator
Create Task
Maniphest T122007

Fix ApiDocumentationTest on CentralAuth
Closed, ResolvedPublic
Actions

Description

Failures from new tests in Ida7e5720fe304c5168fe752b1b5485fe4cb2cb45 needs fixing:

01:39:33 1) ApiDocumentationTest::testDocumentationExists with data set "Module query+globalallusers with MiserMode=false, AllowCategorizedRecentChanges=false" ('query+globalallusers', array(false, false))
01:39:33 DBConnectionError: DB connection error: Access denied for user 'jenkins_u3'@'127.0.0.1' to database 'centralauth' (127.0.0.1:3306)
01:39:33 
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/includes/db/Database.php:871
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/includes/db/loadbalancer/LoadBalancer.php:869
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/includes/db/loadbalancer/LoadBalancer.php:565
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/extensions/CentralAuth/includes/CentralAuthUser.php:127
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/extensions/CentralAuth/includes/CentralAuthUser.php:2738
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/extensions/CentralAuth/includes/api/ApiQueryGlobalAllUsers.php:233
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/includes/api/ApiBase.php:2208
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/includes/TestingAccessWrapper.php:34
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/structure/ApiDocumentationTest.php:80
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/structure/ApiDocumentationTest.php:80
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/MediaWikiTestCase.php:137
01:39:33 
01:39:33 2) ApiDocumentationTest::testDocumentationExists with data set "Module query+globalallusers with MiserMode=true, AllowCategorizedRecentChanges=true" ('query+globalallusers', array(true, true))
01:39:33 DBConnectionError: DB connection error: Access denied for user 'jenkins_u3'@'127.0.0.1' to database 'centralauth' (127.0.0.1:3306)
01:39:33 
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/includes/db/Database.php:871
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/includes/db/loadbalancer/LoadBalancer.php:869
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/includes/db/loadbalancer/LoadBalancer.php:565
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/extensions/CentralAuth/includes/CentralAuthUser.php:127
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/extensions/CentralAuth/includes/CentralAuthUser.php:2738
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/extensions/CentralAuth/includes/api/ApiQueryGlobalAllUsers.php:233
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/includes/api/ApiBase.php:2208
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/includes/TestingAccessWrapper.php:34
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/structure/ApiDocumentationTest.php:80
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/structure/ApiDocumentationTest.php:80
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/MediaWikiTestCase.php:137
01:39:33 
01:39:33 3) ApiDocumentationTest::testDocumentationExists with data set "Module globaluserrights with MiserMode=false, AllowCategorizedRecentChanges=false" ('globaluserrights', array(false, false))
01:39:33 DBConnectionError: DB connection error: Access denied for user 'jenkins_u3'@'127.0.0.1' to database 'centralauth' (127.0.0.1:3306)
01:39:33 
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/includes/db/Database.php:871
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/includes/db/loadbalancer/LoadBalancer.php:869
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/includes/db/loadbalancer/LoadBalancer.php:565
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/extensions/CentralAuth/includes/CentralAuthUser.php:127
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/extensions/CentralAuth/includes/CentralAuthUser.php:2738
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/extensions/CentralAuth/includes/api/ApiGlobalUserRights.php:34
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/includes/api/ApiUserrights.php:113
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/includes/api/ApiBase.php:2208
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/includes/TestingAccessWrapper.php:34
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/structure/ApiDocumentationTest.php:80
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/structure/ApiDocumentationTest.php:80
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/MediaWikiTestCase.php:137
01:39:33 
01:39:33 4) ApiDocumentationTest::testDocumentationExists with data set "Module globaluserrights with MiserMode=true, AllowCategorizedRecentChanges=true" ('globaluserrights', array(true, true))
01:39:33 DBConnectionError: DB connection error: Access denied for user 'jenkins_u3'@'127.0.0.1' to database 'centralauth' (127.0.0.1:3306)
01:39:33 
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/includes/db/Database.php:871
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/includes/db/loadbalancer/LoadBalancer.php:869
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/includes/db/loadbalancer/LoadBalancer.php:565
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/extensions/CentralAuth/includes/CentralAuthUser.php:127
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/extensions/CentralAuth/includes/CentralAuthUser.php:2738
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/extensions/CentralAuth/includes/api/ApiGlobalUserRights.php:34
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/includes/api/ApiUserrights.php:113
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/includes/api/ApiBase.php:2208
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/includes/TestingAccessWrapper.php:34
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/structure/ApiDocumentationTest.php:80
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/structure/ApiDocumentationTest.php:80
01:39:33 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/MediaWikiTestCase.php:137
01:39:33

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add missing API i18n message, and override DB for WMF Jenkinsmediawiki/extensions/CentralAuthmaster+24 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.Dec 20 2015, 3:47 PM
Umherirrender raised the priority of this task from to Needs Triage.
Umherirrender updated the task description. (Show Details)
Umherirrender added projects: MediaWiki-Core-Tests, MediaWiki-extensions-CentralAuth, MediaWiki-Action-API, Continuous-Integration-Infrastructure.
Umherirrender added subscribers: Umherirrender, Anomie.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 20 2015, 3:47 PM
Reedy updated the task description. (Show Details)Dec 20 2015, 4:05 PM
Reedy set Security to None.
Anomie added a comment.Dec 21 2015, 2:32 PM

It looks like something in the CI infrastructure rather than the test itself, since the errors are Access denied for user 'jenkins_u3'@'127.0.0.1' to database 'centralauth'. Do we need to mark the test class as @group Database or something like that to convince the infrastructure to set things up properly?

Anomie moved this task from Unsorted to Non-core-API stuff on the MediaWiki-Action-API board.Dec 21 2015, 2:32 PM
hoo subscribed.Dec 22 2015, 4:39 PM

CentralAuth doesn't create its tables during a update.php run, thus the tables in question aren't there (and neither is the database, for that matter). Not sure how to work around that best… one option would be to just catch such errors and ignore the API modules in question.

gerritbot subscribed.Dec 22 2015, 4:52 PM

Change 260397 had a related patch set uploaded (by Anomie):
Add missing API i18n message, and override DB for WMF Jenkins

https://gerrit.wikimedia.org/r/260397

gerritbot added a project: Patch-For-Review.Dec 22 2015, 4:52 PM
hashar subscribed.Dec 22 2015, 4:55 PM

Since CI only creates a single database, one could look whether $wgWikimediaJenkinsCI is set and set the global. We did that for GlobalBlocking.php

https://gerrit.wikimedia.org/r/#/c/143253/1/GlobalBlocking.php,cm

I am not sure though how you can trigger the update / database setup though.

gerritbot added a comment.Jan 1 2016, 4:43 PM

Change 260397 merged by jenkins-bot:
Add missing API i18n message, and override DB for WMF Jenkins

https://gerrit.wikimedia.org/r/260397

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Jan 1 2016, 5:00 PM
Umherirrender closed this task as Resolved.Jan 1 2016, 5:25 PM
Umherirrender assigned this task to Anomie.
MarcoAurelio moved this task from Backlog to Done on the MediaWiki-extensions-CentralAuth board.Dec 15 2016, 4:18 PM
Umherirrender added a parent task: T154838: Let ApiDocumentationTest structure test pass on all repos.Jan 7 2017, 9:36 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits