Page MenuHomePhabricator
Create Task
Maniphest T122089

Log entries and associated page revisions are not actually associated in the database
Closed, ResolvedPublic
Actions

Description

Log entries and associated page revisions for some actions (upload, move, protect) are not actually associated in the database in any way (other than the title and timestamp hopefully matching). This is inconvenient.

Details

SubjectRepoBranchLines +/-
LogEntry: Make associated rev id persistent (store in logging and log_search)mediawiki/coremaster+62 -10
Option to associate a rev id to a RC log entry, allowing unpatrolled statusmediawiki/coremaster+45 -5
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT134802 Improve the curator workflow for reviewing new files
 OpenNoneT120453 Copyright violation detection tool for Commons
 ResolvedNoneT121870 Improve Special:NewFiles
 ResolvedmatthiasmullieT121865 Allow the same filtering on Special:NewFiles as on Special:NewPages (by tags, username)
 ResolvedmatmarexT121864 Allow various uploading tools on Commons to mark their uploads with change tags
 ResolvedmatmarexT121873 Improve cross-wiki uploads change tag implementation
 ResolvedCenariumT121875 File uploads are not properly tagged (only the log entry, not the revision)
 ResolvedmatthiasmullieT125071 Allow filtering by username on Special:NewFiles
 ResolvedMarosteguiT160415 Review schema changes for T125071 - Add index to image table on all wikis
 OpenNoneT124214 Allow filtering based on tag on Special:NewFiles
 ResolvedmatthiasmullieT122354 Implement 'newbies' mode for Special:NewFiles
 ResolvedmatmarexT124205 Error: 2013 Lost connection to MySQL server during query on NewFilesPager
 OpenNoneT141765 Error: 2013 Lost connection to MySQL server during query on NewFilesPager (again)
 DuplicateFeatureNoneT31793 Check uploaded images with Google image search to find copyright violations
 DuplicateNoneT123517 Automatically check Commons uploads for possible copyright violations
 DuplicateNoneT230561 Create a ML model to score new files in commons for copyvio issues
 ResolvedSamwilsonT145165 Investigation: Copyvio tools for Commons
 OpenNoneT132650 Copyright detection (acoustic fingerprint matching) for audio files
 ResolvedCenariumT127852 Publish of recent change for a log entry should be deferred
 ResolvedCenariumT127848 Should be possible to associate a revision to a log entry without making it unpatrolled
 ResolvedNoneT17644 Enable RevisionDelete on WMF wikis
 OpenNoneT19053 Hiding log entries with RevisionDelete does not automatically hide the corresponding page history entry
 ResolvedGTrangT72518 Tags for page moves should apply to auto-generated edits
 OpenNoneT70950 rc_this_oldid (resp. log_params) should contain revision ID of null revision (resp. redirect) created by moves
 OpenNoneT70936 rc_this_oldid should contain the revision IDs of null revisions created by log events
 ResolvedCenariumT11501 Make file uploads patrollable
 StalledNoneT159028 Unpatrol moved pages on English Wikipedia
 OpenNoneT98617 Make page moves patrollable
 ResolvedmatmarexT122090 ChangeTags::updateTags() should be able to derive log_id from rev_id (and the other way) when applicable
 ResolvedmatmarexT116809 Regular file upload only creates recent changes entry for the log entry (and not the page edit), but maintenance/rebuildrecentchanges.php creates entries for both
 OpenFeatureNoneT22447 RevDelete on revisions related to page moves should show checkboxes to also act upon relevant log entries
 ResolvedCenariumT122089 Log entries and associated page revisions are not actually associated in the database

Event Timeline

matmarex created this task.Dec 21 2015, 10:11 PM
matmarex raised the priority of this task from to Medium.
matmarex updated the task description. (Show Details)
matmarex added a project: MediaWiki-General.
matmarex subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 21 2015, 10:11 PM
gerritbot subscribed.Dec 21 2015, 10:14 PM

Change 211656 had a related patch set uploaded (by Bartosz Dziewoński):
Option to associate a rev id to a RC log entry, allowing unpatrolled status

https://gerrit.wikimedia.org/r/211656

gerritbot added a project: Patch-For-Review.Dec 21 2015, 10:14 PM
matmarex assigned this task to Cenarium.Dec 21 2015, 10:14 PM

(I filed this task for that patch, which previously existed, since I have a few things I want to mark as blocked on this work.)

matmarex added a parent task: T121875: File uploads are not properly tagged (only the log entry, not the revision).Dec 21 2015, 10:15 PM
matmarex added a parent task: T11501: Make file uploads patrollable.
matmarex added a parent task: T122090: ChangeTags::updateTags() should be able to derive log_id from rev_id (and the other way) when applicable.Dec 21 2015, 10:18 PM
matmarex added a parent task: T116809: Regular file upload only creates recent changes entry for the log entry (and not the page edit), but maintenance/rebuildrecentchanges.php creates entries for both.
Ricordisamoa subscribed.Dec 21 2015, 10:24 PM
TTO subscribed.Dec 22 2015, 3:26 AM
Umherirrender added a parent task: T22447: RevDelete on revisions related to page moves should show checkboxes to also act upon relevant log entries.Dec 22 2015, 8:19 PM
Umherirrender added a parent task: T19053: Hiding log entries with RevisionDelete does not automatically hide the corresponding page history entry.
Umherirrender subscribed.Dec 22 2015, 8:22 PM

Can also be used for RevisonDelete. When the value is stored in log_params, it should also be stored in the log_search table

Umherirrender added a parent task: T70950: rc_this_oldid (resp. log_params) should contain revision ID of null revision (resp. redirect) created by moves.Dec 22 2015, 8:27 PM
Umherirrender added a parent task: T70936: rc_this_oldid should contain the revision IDs of null revisions created by log events.Dec 22 2015, 8:29 PM
matmarex added a comment.Dec 22 2015, 8:36 PM
In T122089#1899051, @Umherirrender wrote:

Can also be used for RevisonDelete. When the value is stored in log_params, it should also be stored in the log_search table

Huh, I didn't realize we have a log_search table. I was sad that it won't be queryable when stored in log_params :D

Note that at the moment, https://gerrit.wikimedia.org/r/211656 only stores the associated rev_id in the recentchanges table, which is ephemeral (but that will work for page patrolling and some change tags issues). I think I'll write a separate patch for logging.log_params and log_search.

gerritbot added a comment.Dec 29 2015, 3:26 AM

Change 261314 had a related patch set uploaded (by Bartosz Dziewoński):
LogEntry: Make associated rev id persistent (store in logging and log_search)

https://gerrit.wikimedia.org/r/261314

gerritbot added a comment.Jan 6 2016, 10:04 PM

Change 211656 merged by jenkins-bot:
Option to associate a rev id to a RC log entry, allowing unpatrolled status

https://gerrit.wikimedia.org/r/211656

Nemo_bis subscribed.Jan 6 2016, 10:11 PM
ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Jan 6 2016, 11:00 PM
gerritbot added a comment.Jan 7 2016, 2:33 AM

Change 261314 merged by jenkins-bot:
LogEntry: Make associated rev id persistent (store in logging and log_search)

https://gerrit.wikimedia.org/r/261314

matmarex closed this task as Resolved.Jan 7 2016, 2:34 AM
matmarex removed a project: Patch-For-Review.
matmarex set Security to None.
matmarex awarded a token.
matmarex mentioned this in T70936: rc_this_oldid should contain the revision IDs of null revisions created by log events.Jan 7 2016, 3:27 AM
matmarex added a parent task: T98617: Make page moves patrollable.
matmarex mentioned this in T121873: Improve cross-wiki uploads change tag implementation.Jan 21 2016, 8:24 PM
matmarex added a parent task: T121873: Improve cross-wiki uploads change tag implementation.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL