Page MenuHomePhabricator
Create Task
Maniphest T122113

Get rid of LinksUpdate::setTriggeringUser() hacks
Open, Needs TriagePublic
Actions

Description

The code restored in rMW829c4a8503ea: RefreshLinksJob: Restore LinksUpdate::setTriggeringUser() call isn't ideal, but Echo needs it for now.

Quick notes from IRC for now:

[10:54:20] <AaronSchulz> legoktm: that feature should be re-thought, since I'm not sure how to deal with those problems
[10:55:36] <legoktm> AaronSchulz: Do you have ideas on where else we can hook in to determine when new links get added and by whom?
[10:56:37] <AaronSchulz> using linksupdate hooks is fine for the first part (and does not need triggering user stuff in jobs). The second part is the hard one.
[10:57:28] <AaronSchulz> category membership RC stuff just handles it for direct edits to articles and for unconditional cat links for templates
[10:57:44] <AaronSchulz> for the later it just says "template X (and Y including pages) added to cat Z"
[10:58:12] <AaronSchulz> doesn't enumerate each transcluding page with the author

Related Objects

Event Timeline

Legoktm created this task.Dec 22 2015, 3:51 AM
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added projects: MediaWiki-General, Technical-Debt, Notifications.
Legoktm added subscribers: Legoktm, aaron.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptDec 22 2015, 3:51 AM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript
Danny_B moved this task from Unsorted to Needs removal on the Technical-Debt board.Jan 22 2016, 11:43 PM
Krinkle edited projects, added Technical-Debt (Deprecation process); removed Technical-Debt.Jul 13 2018, 11:10 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 13 2018, 11:10 PM
Krinkle edited projects, added Technical-Debt; removed Technical-Debt (Deprecation process).Jul 13 2018, 11:50 PM
JTannerWMF moved this task from Inbox to Needs Discussion on the Growth-Team board.Jul 18 2018, 6:32 PM
SBisson moved this task from Needs Discussion to Triaged but Future on the Growth-Team board.Jul 20 2018, 6:36 PM
Legoktm mentioned this in T203356: Sort out semantics of causeAgent and triggeringUser/triggeringRevisionId.Sep 12 2018, 5:58 AM
daniel subscribed.Sep 12 2018, 11:15 AM

[10:55:36] <legoktm> AaronSchulz: Do you have ideas on where else we can hook in to determine when new links get added and by whom?[10:55:36] <legoktm> AaronSchulz: Do you have ideas on where else we can hook in to determine when new links get added and by whom?

I don't understand the problem. The LinksUpdate hook gets a LinksUpdate object. It can call $this->getRevision()->getUser() to find out who changed the links, and $this->getAddLinkes() to list the new links.

Now, $this->getRevision()->getUser() is not necessarily the user who triggered the update (e.g. in case of a purge or null edit, it may well be a different user). But the triggering user is NOT the user who added the links! The links where added by the user returned by $this->getRevision()->getUser(), no?

SBisson mentioned this in W2269 Echo Tasks.Apr 17 2019, 3:31 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:59 PM
Aklapper removed a project: Collaboration-Team-Triage.May 25 2021, 9:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL