Page MenuHomePhabricator

mw.widgets.CategorySelector can have duplicate categories entered
Closed, ResolvedPublic

Description

mw.widgets.CategorySelector can have duplicate categories entered, which is not supposed to happen.

The problem is that we're checking for duplicates before canonicalizing the title. So, if there's already "Category:Foo" in the input, and the user inputs "foo", "Category:Foo" and "Category:foo" are not equal; "Category:foo" is added and canonicalized to "Category:Foo"; and now we have it twice.

Event Timeline

matmarex created this task.Dec 22 2015, 5:11 PM
matmarex updated the task description. (Show Details)
matmarex raised the priority of this task from to Needs Triage.
matmarex added a project: MediaWiki-Interface.
matmarex added a subscriber: matmarex.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 22 2015, 5:11 PM
matmarex claimed this task.Dec 22 2015, 5:12 PM

Change 260612 had a related patch set uploaded (by Bartosz Dziewoński):
mw.widgets.CategorySelector: Prevent duplicates

https://gerrit.wikimedia.org/r/260612

matmarex triaged this task as Normal priority.Dec 22 2015, 7:46 PM

Change 260612 merged by jenkins-bot:
mw.widgets.CategorySelector: Prevent duplicates

https://gerrit.wikimedia.org/r/260612

Prtksxna closed this task as Resolved.Dec 23 2015, 1:18 PM
Prtksxna added a subscriber: Prtksxna.