mw.widgets.CategorySelector can have duplicate categories entered
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Dec 22 2015, 5:11 PM

Description

mw.widgets.CategorySelector can have duplicate categories entered, which is not supposed to happen.

The problem is that we're checking for duplicates before canonicalizing the title. So, if there's already "Category:Foo" in the input, and the user inputs "foo", "Category:Foo" and "Category:foo" are not equal; "Category:foo" is added and canonicalized to "Category:Foo"; and now we have it twice.

Details

	Subject	Repo	Branch	Lines +/-
	mw.widgets.CategorySelector: Prevent duplicates	mediawiki/core	master	+10 -0

Customize query in gerrit

Event Timeline

matmarex created this task.Dec 22 2015, 5:11 PM

matmarex raised the priority of this task from to Needs Triage.

matmarex updated the task description. (Show Details)

matmarex added a project: MediaWiki-User-Interface.

matmarex subscribed.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 22 2015, 5:11 PM

matmarex claimed this task.Dec 22 2015, 5:12 PM

Change 260612 had a related patch set uploaded (by Bartosz Dziewoński):
mw.widgets.CategorySelector: Prevent duplicates

https://gerrit.wikimedia.org/r/260612

gerritbot added a project: Patch-For-Review.Dec 22 2015, 6:26 PM

matmarex triaged this task as Medium priority.Dec 22 2015, 7:46 PM

Change 260612 merged by jenkins-bot:
mw.widgets.CategorySelector: Prevent duplicates

https://gerrit.wikimedia.org/r/260612

• Prtksxna closed this task as Resolved.Dec 23 2015, 1:18 PM

• Prtksxna subscribed.

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), MW-1.27-release-notes.Dec 23 2015, 2:00 PM

mw.widgets.CategorySelector can have duplicate categories enteredClosed, ResolvedPublicActions

Description

Details

Event Timeline

mw.widgets.CategorySelector can have duplicate categories entered
Closed, ResolvedPublic
Actions