when forgetting a newline after translate marker VE doesn't display the real error message
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	JanZerebecki
	Dec 23 2015, 6:02 AM

Description

VE error: The modification you tried to make was aborted by an extension hook
Source editor error:

Translation unit markers in unexpected position. 
Translation unit text:

<!--T:83-->In general it is preferred to share code via composer components instead of extensions. If the classes of an extension only need to exist, but the extension does not need to be configured nor loaded, for what you want to do, that is a strong indicator that that code should be split off into a composer component you should depend on instead.

Found during https://www.mediawiki.org/w/index.php?title=Manual%3AExtension_registration&type=revision&diff=1974486&oldid=1974468 .

Event Timeline

JanZerebecki created this task.Dec 23 2015, 6:02 AM

JanZerebecki raised the priority of this task from to Needs Triage.

JanZerebecki updated the task description. (Show Details)

JanZerebecki added projects: VisualEditor, MediaWiki-extensions-Translate.

JanZerebecki subscribed.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 23 2015, 6:02 AM

Jdforrester-WMF triaged this task as Lowest priority.Jan 12 2016, 8:25 PM

Jdforrester-WMF set Security to None.

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.

If you request a change in Translate, please state what that is explicitly.

Nikerabbit moved this task from Backlog to cross projects on the MediaWiki-extensions-Translate board.Jan 22 2016, 3:55 PM

I only described the problem a user experiences. The next step is finding a solution, do you have a suggestion how either VE or Translate could be modified to solve this?

Well, editing translatable pages with VE is not currently a supported use case, so I am not sure whether anything needs to be done until it is. I could make Translate extension more lenient on the placing of the tags with slightly increased risk that some bad changes get through.

In T122276#1958894, @Nikerabbit wrote:

Well, editing translatable pages with VE is not currently a supported use case, so I am not sure whether anything needs to be done until it is.

It would be helpful if the error from Translate could actually be read by the user, instead of hiding it behind a generic message. (As it is when making the same edit with the source editor.)

I could make Translate extension more lenient on the placing of the tags with slightly increased risk that some bad changes get through.

I don't think that fixes the issue, as that would still leave other Translate syntax errors, that need to be displayed to the user.

OK. Please let me know if changes in Translate are needed to display the errors correctly in VE. As far as I know I am using the hooks correctly to report the errors.

It has been fixed some time in the past five years, now a proper error message is shown:

Screenshot_2021-07-31 Manual Extension registration - MediaWiki.png (451×498 px, 37 KB)

	F34571256: Screenshot_2021-07-31 Manual Extension registration - MediaWiki.png
	Jul 31 2021, 1:13 PM

when forgetting a newline after translate marker VE doesn't display the real error messageClosed, ResolvedPublicActions

Description

Event Timeline

when forgetting a newline after translate marker VE doesn't display the real error message
Closed, ResolvedPublic
Actions