I was being really stupid today, and forgot to urlencode '+' when using checktoken module. It'd be cool for people making that stupid mistake, if the api module gave a warning if the proposed token ends in a space followed by a \.
The output when done properly should look something like this:
{ "warnings": { "checktoken": { "*": "Check that symbols such as \"+\" in the token are properly percent-encoded in the URL." } }, "checktoken": { "result": "invalid" } }
| mediawiki/core : master | Added warning for improper ending of a token |
| mediawiki/core : master | Fix token match warning for token ending improperly |
| mediawiki/core : master | Fix token match warning for token ending improperly |
| mediawiki/core : master | ix token match warning for token ending improperly |
| mediawiki/core : master | Fix token match warning for token ending improperly |
Somewhat more usefully, check if the proposed token ends with urldecode( User::EDIT_TOKEN_SUFFIX ) instead of hard-coding ' \'.
@somethingsea: Welcome and thanks for working on this! If you need any help, don't hesitate to ask!
I would like to work on this bug? As there are no patches submitted yet, is it possible for me to assign the task to myself and submit a patch?
If @somethingsea doesn't reply soon, feel free to unlick the cookie by assigning it to yourself.
Change 320072 had a related patch set uploaded (by Harish halo):
Fix token match warning for token ending improperly
Change 320072 abandoned by Harish halo:
Fix token match warning for token ending improperly
Change 320073 had a related patch set uploaded (by Harish halo):
Fix token match warning for token ending improperly
Change 320075 had a related patch set uploaded (by Harish halo):
ix token match warning for token ending improperly
Change 320073 abandoned by Harish halo:
Fix token match warning for token ending improperly
Change 320075 abandoned by Harish halo:
ix token match warning for token ending improperly
Change 320076 had a related patch set uploaded (by Harish halo):
Fix token match warning for token ending improperly
Change 320076 abandoned by Harish halo:
Fix token match warning for token ending improperly
Change 323896 had a related patch set uploaded (by Georggi199):
Added warning for improper ending of a token
Since this has been posted for GCI and none of the three attempts so far have come close to being correct, I added some detail to the task description as to what the output will look like if this task is done correctly.
Also, a hint: You'll want to look at the ApiBase class documentation, particularly the section for "Warning and error reporting" methods.