Page MenuHomePhabricator

X icon in ContentTranslation's MT card is not well aligned
Closed, InvalidPublic

Description

Seen in Image posted by Santhosh at https://i.imgur.com/yWkDjiC.png. It feels too close to the left border.

The paste icon is 16x16 while the cross is 13x13, but both use background-position: left 4px center.

Event Timeline

Nikerabbit raised the priority of this task from to Needs Triage.
Nikerabbit updated the task description. (Show Details)
Nikerabbit added a subscriber: Nikerabbit.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 23 2015, 9:42 AM
Abhinand claimed this task.Dec 24 2015, 9:41 AM
Abhinand set Security to None.

Should I make it centered or add some space to left. I think centering it will look good.

The space for the icon is reserved with padding, so it doesn't have its own enclosing element. Plainly centering the icon won't work in this case.

Amire80 renamed this task from X icon in MT card is not well aligned to X icon in ContentTranslation's MT card is not well aligned.Dec 31 2015, 8:34 AM
Amire80 triaged this task as Normal priority.
Amire80 moved this task from Needs Triage to CX8 candidates on the ContentTranslation board.
Amire80 added a project: WorkType-Maintenance.

Where can I find the image posted above ?

ContentTranslation/modules/tools/images/ contains the icons.

Where can i find this in mediawiki ?

MtDu added a subscriber: MtDu.Jan 12 2016, 10:30 PM

@Abhinand,
You can find it in the mediawiki extension ContentTranslation. If you do not have it, go to gerrit.wikimedia.org go to the project section, go to list, search for the extension, and clone it. Then, use the path given by Nikerabbit to find the location of the image. :)
MtDu

MtDu added a comment.Jan 25 2016, 7:29 PM

@Nikerabbit,
What do you think is the best positioning? I can override it in the specific x-icon class. Does background-position: left 5px center sound good? (I haven't gotten around to updating my vagrant instance, so I can't test a this moment. :p)
Thanks,
MtDu

Perhaps @Pginer-WMF knows? My simplistic guess would be to have equal amount of whitespace on all slides.

Can I make it as background-position: left 5px center ?

santhosh closed this task as Invalid.Jul 7 2016, 5:50 AM
santhosh added a subscriber: santhosh.

We are changing the design of MT card as per T130594: Simplify the "Automatic translation" card. So this ticket is no longer valid

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJul 7 2016, 5:50 AM
Abhinand removed Abhinand as the assignee of this task.Jul 7 2016, 5:52 AM
Abhinand added a subscriber: Abhinand.